Re: [PATCH iproute2 2/2] devlink: fix libc and kernel headers collision

2019-06-25 Thread Stephen Hemminger
On Tue, 25 Jun 2019 14:49:05 +0300 Baruch Siach wrote: > +/* Suppress linux/sysinfo.h to avoid > + * collision of struct sysinfo definition > + * with musl libc headers > + */ You only need a small comment for this. #define _LINUX_SYSINFO_H /* avoid collision with musl header */

[PATCH iproute2 2/2] devlink: fix libc and kernel headers collision

2019-06-25 Thread Baruch Siach
Since commit 2f1242efe9d ("devlink: Add devlink health show command") we use the sys/sysinfo.h header for the sysinfo(2) system call. But since iproute2 carries a local version of the kernel struct sysinfo, this causes a collision with libc that do not rely on kernel defined sysinfo like musl libc: