Re: [PATCH iproute2 1/2] devlink: fix format string warning for 32bit targets

2019-06-26 Thread Stephen Hemminger
On Wed, 26 Jun 2019 06:30:44 +0300 Baruch Siach wrote: > Hi Stephen, > > On Tue, Jun 25, 2019 at 11:58:06AM -0700, Stephen Hemminger wrote: > > On Tue, 25 Jun 2019 14:49:04 +0300 > > Baruch Siach wrote: > > > > > diff --git a/devlink/devlink.c b/devlink/devlink.c > > > index 436935f88bda..b4

Re: [PATCH iproute2 1/2] devlink: fix format string warning for 32bit targets

2019-06-25 Thread Baruch Siach
Hi Stephen, On Tue, Jun 25, 2019 at 11:58:06AM -0700, Stephen Hemminger wrote: > On Tue, 25 Jun 2019 14:49:04 +0300 > Baruch Siach wrote: > > > diff --git a/devlink/devlink.c b/devlink/devlink.c > > index 436935f88bda..b400fab17578 100644 > > --- a/devlink/devlink.c > > +++ b/devlink/devlink.c >

Re: [PATCH iproute2 1/2] devlink: fix format string warning for 32bit targets

2019-06-25 Thread Stephen Hemminger
On Tue, 25 Jun 2019 14:49:04 +0300 Baruch Siach wrote: > diff --git a/devlink/devlink.c b/devlink/devlink.c > index 436935f88bda..b400fab17578 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -1726,9 +1726,9 @@ static void pr_out_u64(struct dl *dl, const char *name, > uint64_t val

[PATCH iproute2 1/2] devlink: fix format string warning for 32bit targets

2019-06-25 Thread Baruch Siach
32bit targets define uint64_t as long long unsigned. This leads to the following build warning: devlink.c: In function ‘pr_out_u64’: devlink.c:1729:11: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t {aka long long unsigned int}’ [-Wformat=]