Re: [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing

2020-11-24 Thread Jamal Hadi Salim
On 2020-11-24 7:13 a.m., Roi Dayan wrote: On 2020-11-24 11:39 AM, Roi Dayan wrote: [..] Hi, I didn't debug yet but with this commit I am failing to add a tc rule I always could before. also the error msg doesn't make sense. Example: # tc filter add dev enp8s0f0 protocol 802.1Q parent f

Re: [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing

2020-11-24 Thread Roi Dayan
On 2020-11-24 11:39 AM, Roi Dayan wrote: On 2020-11-14 5:12 AM, David Ahern wrote: On 11/10/20 12:53 AM, Zahari Doychev wrote: Currently the icmp and arp parsing functions are called with incorrect ethtype in case of vlan or cvlan filter options. In this case either cvlan_ethtype or vlan_e

Re: [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing

2020-11-24 Thread Roi Dayan
On 2020-11-14 5:12 AM, David Ahern wrote: On 11/10/20 12:53 AM, Zahari Doychev wrote: Currently the icmp and arp parsing functions are called with incorrect ethtype in case of vlan or cvlan filter options. In this case either cvlan_ethtype or vlan_ethtype has to be used. The ethtype is now up

Re: [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing

2020-11-13 Thread David Ahern
On 11/10/20 12:53 AM, Zahari Doychev wrote: > Currently the icmp and arp parsing functions are called with incorrect > ethtype in case of vlan or cvlan filter options. In this case either > cvlan_ethtype or vlan_ethtype has to be used. The ethtype is now updated > each time a vlan ethtype is matche

[PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing

2020-11-09 Thread Zahari Doychev
Currently the icmp and arp parsing functions are called with incorrect ethtype in case of vlan or cvlan filter options. In this case either cvlan_ethtype or vlan_ethtype has to be used. The ethtype is now updated each time a vlan ethtype is matched during parsing. Signed-off-by: Zahari Doychev --