Re: [PATCH iproute2-next 2/3] tc: add mpls actions

2019-07-09 Thread Stephen Hemminger
On Tue, 9 Jul 2019 14:36:34 -0600 David Ahern wrote: > On 7/9/19 11:00 AM, Stephen Hemminger wrote: > > On Tue, 9 Jul 2019 16:59:31 +0100 > > John Hurley wrote: > > > >>if (!tb[TCA_MPLS_PARMS]) { > >> + print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]"); > > > > Thi

Re: [PATCH iproute2-next 2/3] tc: add mpls actions

2019-07-09 Thread David Ahern
On 7/9/19 9:59 AM, John Hurley wrote: > +static void explain(void) > +{ > + fprintf(stderr, > + "Usage: mpls pop [ protocol MPLS_PROTO ]\n" > + " mpls push [ protocol MPLS_PROTO ] [ label MPLS_LABEL ] > [ tc MPLS_TC ] [ ttl MPLS_TTL ] [ bos MPLS_BOS ] [CONTROL]\

Re: [PATCH iproute2-next 2/3] tc: add mpls actions

2019-07-09 Thread David Ahern
On 7/9/19 11:00 AM, Stephen Hemminger wrote: > On Tue, 9 Jul 2019 16:59:31 +0100 > John Hurley wrote: > >> if (!tb[TCA_MPLS_PARMS]) { >> +print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]"); > > This is an error message please just use fprintf(stderr instead > skbedi

Re: [PATCH iproute2-next 2/3] tc: add mpls actions

2019-07-09 Thread Stephen Hemminger
On Tue, 9 Jul 2019 16:59:31 +0100 John Hurley wrote: > if (!tb[TCA_MPLS_PARMS]) { > + print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]"); This is an error message please just use fprintf(stderr instead

[PATCH iproute2-next 2/3] tc: add mpls actions

2019-07-09 Thread John Hurley
Create a new action type for TC that allows the pushing, popping, and modifying of MPLS headers. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- tc/Makefile | 1 + tc/m_mpls.c | 275 2 files changed, 276 insertions(+) cr