Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-22 Thread Petr Machata
On October 22, 2020 2:11:01 AM GMT+02:00, Stephen Hemminger wrote: >On Thu, 22 Oct 2020 01:48:58 +0200 >Petr Machata wrote: > >> Stephen Hemminger writes: >> >> > On Tue, 20 Oct 2020 22:43:37 +0200 >> > Petr Machata wrote: >> > >> >> Jakub Kicinski writes: >> >> >> >> > On Tue, 20 Oct

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-21 Thread Stephen Hemminger
On Thu, 22 Oct 2020 01:48:58 +0200 Petr Machata wrote: > Stephen Hemminger writes: > > > On Tue, 20 Oct 2020 22:43:37 +0200 > > Petr Machata wrote: > > > >> Jakub Kicinski writes: > >> > >> > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: > >> >> +static void dcb_ets_print_cbs(F

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-21 Thread Petr Machata
Stephen Hemminger writes: > On Tue, 20 Oct 2020 22:43:37 +0200 > Petr Machata wrote: > >> Jakub Kicinski writes: >> >> > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: >> >> +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets) >> >> +{ >> >> + print_string(PRINT_ANY, "

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-21 Thread Stephen Hemminger
On Tue, 20 Oct 2020 22:43:37 +0200 Petr Machata wrote: > Jakub Kicinski writes: > > > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: > >> +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets) > >> +{ > >> + print_string(PRINT_ANY, "cbs", "cbs %s ", ets->cbs ? "on" : "o

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-20 Thread Petr Machata
Jakub Kicinski writes: > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: >> +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets) >> +{ >> +print_string(PRINT_ANY, "cbs", "cbs %s ", ets->cbs ? "on" : "off"); >> +} > > I'd personally lean in the direction ethtool is tak

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: > +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets) > +{ > + print_string(PRINT_ANY, "cbs", "cbs %s ", ets->cbs ? "on" : "off"); > +} I'd personally lean in the direction ethtool is taking and try to limit string values

[PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-19 Thread Petr Machata
ETS, for "Enhanced Transmission Selection", is a set of configurations that permit configuration of mapping of priorities to traffic classes, traffic selection algorithm to use per traffic class, bandwidth allocation, etc. Add a dcb subtool to allow showing and tweaking of individual ETS configura