Re: [PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in rta_nest

2019-05-30 Thread Michal Kubecek
On Thu, May 30, 2019 at 11:50:59AM -0600, David Ahern wrote: > On 5/30/19 11:43 AM, Stephen Hemminger wrote: > > > > I assume older kernels ignore the attribute? > > > > Also, how is this opt-in for running iproute2-next on old kernels? > > from what I can see older kernel added the flag when ge

Re: [PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in rta_nest

2019-05-30 Thread David Ahern
On 5/30/19 11:43 AM, Stephen Hemminger wrote: > > I assume older kernels ignore the attribute? > > Also, how is this opt-in for running iproute2-next on old kernels? > from what I can see older kernel added the flag when generating a nest (users of nla_nest_start), but did not pay attention to

Re: [PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in rta_nest

2019-05-30 Thread Stephen Hemminger
On Wed, 29 May 2019 20:17:38 -0700 David Ahern wrote: > From: David Ahern > > Kernel now requires NLA_F_NESTED to be set on new nested > attributes. Set NLA_F_NESTED in rta_nest. > > Signed-off-by: David Ahern > --- > lib/libnetlink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

[PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in rta_nest

2019-05-29 Thread David Ahern
From: David Ahern Kernel now requires NLA_F_NESTED to be set on new nested attributes. Set NLA_F_NESTED in rta_nest. Signed-off-by: David Ahern --- lib/libnetlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/libnetlink.c b/lib/libnetlink.c index 0d48a3d43cf0..6ae51a9dba14 100644 -