Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-24 Thread Roman Mashak
David Ahern writes: > On 5/17/20 7:28 AM, Roman Mashak wrote: >> Have print_tm() dump firstuse value along with install, lastuse >> and expires. >> >> Signed-off-by: Roman Mashak >> --- >> tc/tc_util.c | 5 + >> 1 file changed, 5 insertions(+) >> > > I can merge master once Stephen commit

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-19 Thread David Ahern
On 5/17/20 7:28 AM, Roman Mashak wrote: > Have print_tm() dump firstuse value along with install, lastuse > and expires. > > Signed-off-by: Roman Mashak > --- > tc/tc_util.c | 5 + > 1 file changed, 5 insertions(+) > I can merge master once Stephen commits the bug fix. Then resubmit this p

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-19 Thread David Ahern
On 5/19/20 12:08 PM, Stephen Hemminger wrote: >> Last time this function was touched in commit >> 2704bd62558391c00bc1c3e7f8706de8332d8ba0 where json was added. > > iproute commands are not supposed to expose the jiffies version of > times in input or output. > Check your queue; I brought this

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-19 Thread Stephen Hemminger
On Mon, 18 May 2020 12:41:10 -0400 Roman Mashak wrote: > David Ahern writes: > > > On 5/17/20 7:28 AM, Roman Mashak wrote: > >> Have print_tm() dump firstuse value along with install, lastuse > >> and expires. > >> > >> Signed-off-by: Roman Mashak > >> --- > >> tc/tc_util.c | 5 + > >>

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-19 Thread Stephen Hemminger
On Sun, 17 May 2020 09:28:45 -0400 Roman Mashak wrote: > + if (tm->firstuse != 0) { > + print_uint(PRINT_JSON, "first_used", NULL, tm->firstuse); > + print_uint(PRINT_FP, NULL, " firstused %u sec", > +(unsigned int)(tm->firstuse/hz)); > + }

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-19 Thread Jamal Hadi Salim
On 2020-05-18 11:38 a.m., David Ahern wrote: On 5/18/20 7:10 AM, Jamal Hadi Salim wrote: On 2020-05-17 9:28 a.m., Roman Mashak wrote: Have print_tm() dump firstuse value along with install, lastuse and expires. Signed-off-by: Roman Mashak ---   tc/tc_util.c | 5 +   1 file changed, 5 ins

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-18 Thread Roman Mashak
David Ahern writes: > On 5/17/20 7:28 AM, Roman Mashak wrote: >> Have print_tm() dump firstuse value along with install, lastuse >> and expires. >> >> Signed-off-by: Roman Mashak >> --- >> tc/tc_util.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/tc/tc_util.c b/tc/tc_util.

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-18 Thread David Ahern
On 5/18/20 7:10 AM, Jamal Hadi Salim wrote: > On 2020-05-17 9:28 a.m., Roman Mashak wrote: >> Have print_tm() dump firstuse value along with install, lastuse >> and expires. >> >> Signed-off-by: Roman Mashak >> --- >>   tc/tc_util.c | 5 + >>   1 file changed, 5 insertions(+) >> >> diff --git a

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-18 Thread David Ahern
On 5/17/20 7:28 AM, Roman Mashak wrote: > Have print_tm() dump firstuse value along with install, lastuse > and expires. > > Signed-off-by: Roman Mashak > --- > tc/tc_util.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tc/tc_util.c b/tc/tc_util.c > index 12f865cc71bf..f6aa2ed55

Re: [PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-18 Thread Jamal Hadi Salim
On 2020-05-17 9:28 a.m., Roman Mashak wrote: Have print_tm() dump firstuse value along with install, lastuse and expires. Signed-off-by: Roman Mashak --- tc/tc_util.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tc/tc_util.c b/tc/tc_util.c index 12f865cc71bf..f6aa2ed552a9 100644

[PATCH iproute2-next 1/1] tc: report time an action was first used

2020-05-17 Thread Roman Mashak
Have print_tm() dump firstuse value along with install, lastuse and expires. Signed-off-by: Roman Mashak --- tc/tc_util.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tc/tc_util.c b/tc/tc_util.c index 12f865cc71bf..f6aa2ed552a9 100644 --- a/tc/tc_util.c +++ b/tc/tc_util.c @@ -760,6 +