Re: [PATCH iproute2-next] treewide: refactor help messages

2019-05-20 Thread David Ahern
On 5/17/19 7:38 AM, Matteo Croce wrote: > Every tool in the iproute2 package have one or more function to show > an help message to the user. Some of these functions print the help > line by line with a series of printf call, e.g. ip/xfrm_state.c does > 60 fprintf calls. > If we group all the calls

Re: [PATCH iproute2-next] treewide: refactor help messages

2019-05-17 Thread Stephen Hemminger
On Fri, 17 May 2019 15:38:28 +0200 Matteo Croce wrote: > Every tool in the iproute2 package have one or more function to show > an help message to the user. Some of these functions print the help > line by line with a series of printf call, e.g. ip/xfrm_state.c does > 60 fprintf calls. > If we gr

[PATCH iproute2-next] treewide: refactor help messages

2019-05-17 Thread Matteo Croce
Every tool in the iproute2 package have one or more function to show an help message to the user. Some of these functions print the help line by line with a series of printf call, e.g. ip/xfrm_state.c does 60 fprintf calls. If we group all the calls to a single one and just concatenate strings, we