Re: [PATCH iproute2-next] tc: implement support for action terse dump

2020-11-06 Thread Vlad Buslov
On Tue 03 Nov 2020 at 23:59, Jamal Hadi Salim wrote: > On 2020-11-03 10:07 a.m., Vlad Buslov wrote: >> >> On Tue 03 Nov 2020 at 03:48, David Ahern wrote: >>> On 10/31/20 2:25 PM, Vlad Buslov wrote: diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h inde

Re: [PATCH iproute2-next] tc: implement support for action terse dump

2020-11-06 Thread Jakub Kicinski
On Fri, 6 Nov 2020 13:25:19 -0700 David Ahern wrote: > On 11/6/20 12:16 PM, Vlad Buslov wrote: > >>> > >> > >> Its unfortunate that the TCA_ prefix ended being used for both filters > >> and actions. Since we only have a couple of flags maybe it is not too > >> late to have a prefix TCAA_ ? For e

Re: [PATCH iproute2-next] tc: implement support for action terse dump

2020-11-06 Thread David Ahern
On 11/6/20 12:16 PM, Vlad Buslov wrote: >>> >> >> Its unfortunate that the TCA_ prefix ended being used for both filters >> and actions. Since we only have a couple of flags maybe it is not too >> late to have a prefix TCAA_ ? For existing flags something like a >> #define TCAA_FLAG_LARGE_DUMP_ON T

Re: [PATCH iproute2-next] tc: implement support for action terse dump

2020-11-03 Thread Jamal Hadi Salim
On 2020-11-03 10:07 a.m., Vlad Buslov wrote: On Tue 03 Nov 2020 at 03:48, David Ahern wrote: On 10/31/20 2:25 PM, Vlad Buslov wrote: diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index 5ad84e663d01..b486f52900f0 100644 --- a/include/uapi/linux/rtnetlink.h +++ b/

Re: [PATCH iproute2-next] tc: implement support for action terse dump

2020-11-03 Thread Vlad Buslov
On Tue 03 Nov 2020 at 03:48, David Ahern wrote: > On 10/31/20 2:25 PM, Vlad Buslov wrote: >> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h >> index 5ad84e663d01..b486f52900f0 100644 >> --- a/include/uapi/linux/rtnetlink.h >> +++ b/include/uapi/linux/rtnetlink.h >>

Re: [PATCH iproute2-next] tc: implement support for action terse dump

2020-11-02 Thread David Ahern
On 10/31/20 2:25 PM, Vlad Buslov wrote: > diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h > index 5ad84e663d01..b486f52900f0 100644 > --- a/include/uapi/linux/rtnetlink.h > +++ b/include/uapi/linux/rtnetlink.h > @@ -768,8 +768,12 @@ enum { > * actions in a dump. All d

[PATCH iproute2-next] tc: implement support for action terse dump

2020-10-31 Thread Vlad Buslov
Implement support for action terse dump using new TCA_FLAG_TERSE_DUMP value of TCA_ROOT_FLAGS tlv. Set the flag when user requested it with following example CLI (-br for 'brief'): $ tc -s -br actions ls action tunnel_key total acts 2 action order 0: tunnel_key index 1 Actio