Re: [PATCH iproute2-next] tc: add support for plug qdisc

2019-04-30 Thread Paolo Abeni
On Mon, 2019-04-29 at 10:16 -0700, Stephen Hemminger wrote: > On Fri, 26 Apr 2019 10:47:52 +0200 > Paolo Abeni wrote: > > The problem here is that the sch_plug qdisc does not implement the > > dump() qdisc_op, so this callback has nothing to dump. > > > > Must I patch sch_plug first? > > > > Tha

Re: [PATCH iproute2-next] tc: add support for plug qdisc

2019-04-29 Thread Stephen Hemminger
On Fri, 26 Apr 2019 10:47:52 +0200 Paolo Abeni wrote: > Hi, > > On Wed, 2019-04-24 at 13:49 -0700, Stephen Hemminger wrote: > > On Wed, 24 Apr 2019 18:29:39 +0200 > > Paolo Abeni wrote: > > > > > +static int plug_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr > > > *opt) > > > +{ >

Re: [PATCH iproute2-next] tc: add support for plug qdisc

2019-04-26 Thread Paolo Abeni
Hi, On Wed, 2019-04-24 at 13:49 -0700, Stephen Hemminger wrote: > On Wed, 24 Apr 2019 18:29:39 +0200 > Paolo Abeni wrote: > > > +static int plug_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr > > *opt) > > +{ > > + /* dummy implementation as sch_plug does not implement a dump op */ >

Re: [PATCH iproute2-next] tc: add support for plug qdisc

2019-04-24 Thread Stephen Hemminger
On Wed, 24 Apr 2019 18:29:39 +0200 Paolo Abeni wrote: > +static int plug_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) > +{ > + /* dummy implementation as sch_plug does not implement a dump op */ > + return 0; > +} > + All qdisc must dump their state in same form as the p

Re: [PATCH iproute2-next] tc: add support for plug qdisc

2019-04-24 Thread Stephen Hemminger
On Wed, 24 Apr 2019 18:29:39 +0200 Paolo Abeni wrote: > @@ -0,0 +1,81 @@ > +/* > + * q_log.c plug scheduler > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as

[PATCH iproute2-next] tc: add support for plug qdisc

2019-04-24 Thread Paolo Abeni
sch_plug can be used to perform functional qdisc unit tests controlling explicitly the queuing behaviour from user-space. Plug support lacks since its introduction in 2012. This change introduces basic support, to control the tc status. Signed-off-by: Paolo Abeni --- tc/Makefile | 1 + tc/q_pl