Re: [PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-22 Thread David Ahern
On 9/16/20 1:42 PM, Jakub Kicinski wrote: > missed_packet_errors are much more commonly reported: > > linux$ git grep -c '[.>]rx_missed_errors ' -- drivers/ | wc -l > 64 > linux$ git grep -c '[.>]rx_over_errors ' -- drivers/ | wc -l > 37 > > Plus those drivers are generally more modern than those

Re: [PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-21 Thread Jakub Kicinski
On Sat, 19 Sep 2020 09:06:58 -0700 Stephen Hemminger wrote: > > > Does that mean "no" or "you need to be more convincing"? :) > > > > > > JSON output is not changed. I don't think we care about screen > > > scrapers. If we cared about people how interpret values based > > > on their position in t

Re: [PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-19 Thread Stephen Hemminger
On Fri, 18 Sep 2020 22:52:56 -0600 David Ahern wrote: > On 9/18/20 9:48 AM, Jakub Kicinski wrote: > > On Fri, 18 Sep 2020 09:44:35 -0600 David Ahern wrote: > >> On 9/16/20 1:42 PM, Jakub Kicinski wrote: > >>> 2: eth0: mtu 1500 qdisc mq state UP > >>> mode DEFAULT group default qlen 1000 > >

Re: [PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-18 Thread David Ahern
On 9/18/20 9:48 AM, Jakub Kicinski wrote: > On Fri, 18 Sep 2020 09:44:35 -0600 David Ahern wrote: >> On 9/16/20 1:42 PM, Jakub Kicinski wrote: >>> 2: eth0: mtu 1500 qdisc mq state UP mode >>> DEFAULT group default qlen 1000 >>> link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff >>> RX: by

Re: [PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-18 Thread Jakub Kicinski
On Fri, 18 Sep 2020 09:44:35 -0600 David Ahern wrote: > On 9/16/20 1:42 PM, Jakub Kicinski wrote: > > 2: eth0: mtu 1500 qdisc mq state UP mode > > DEFAULT group default qlen 1000 > > link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff > > RX: bytes packets errors dropped overrun mcast >

Re: [PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-18 Thread David Ahern
On 9/16/20 1:42 PM, Jakub Kicinski wrote: > missed_packet_errors are much more commonly reported: > > linux$ git grep -c '[.>]rx_missed_errors ' -- drivers/ | wc -l > 64 > linux$ git grep -c '[.>]rx_over_errors ' -- drivers/ | wc -l > 37 > > Plus those drivers are generally more modern than those

[PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-16 Thread Jakub Kicinski
missed_packet_errors are much more commonly reported: linux$ git grep -c '[.>]rx_missed_errors ' -- drivers/ | wc -l 64 linux$ git grep -c '[.>]rx_over_errors ' -- drivers/ | wc -l 37 Plus those drivers are generally more modern than those using rx_over_errors. Since recently merged kernel docum