Re: [PATCH iproute2-net 2/3] devlink: Add pr_out_dev() helper function

2020-12-01 Thread Moshe Shemesh
On 11/29/2020 11:15 PM, David Ahern wrote: On 11/26/20 4:14 AM, Moshe Shemesh wrote: diff --git a/devlink/devlink.c b/devlink/devlink.c index a9ba0072..bd588869 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -2974,17 +2974,11 @@ static int cmd_dev_param(struct dl *dl) pr_err

Re: [PATCH iproute2-net 2/3] devlink: Add pr_out_dev() helper function

2020-11-29 Thread David Ahern
On 11/26/20 4:14 AM, Moshe Shemesh wrote: > diff --git a/devlink/devlink.c b/devlink/devlink.c > index a9ba0072..bd588869 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -2974,17 +2974,11 @@ static int cmd_dev_param(struct dl *dl) > pr_err("Command \"%s\" not found\n", dl_argv

[PATCH iproute2-net 2/3] devlink: Add pr_out_dev() helper function

2020-11-26 Thread Moshe Shemesh
Add pr_out_dev() helper function and use it both by cmd_dev_show_cb() and by cmd_mon_show_cb(). Dev stats will be added on the next patch to dev context, so cmd_mon_show_cb() should print the whole dev context and not just dev handle. Signed-off-by: Moshe Shemesh Reviewed-by: Jiri Pirko --- de