Re: [PATCH iproute2] nstat: case-insensitive pattern matching

2020-07-08 Thread Anton Danilov
Hello, Stephen. Thanks for feedback. > Why not just make it the default? > I can't imagine a scenario where user would want to match on icmp different > than ICMP Yes, I'm agreed. I'll make it the default in the v2 patch. > Perhaps it should also be applied to ifstat and ss. I'll prepare the

Re: [PATCH iproute2] nstat: case-insensitive pattern matching

2020-07-08 Thread Stephen Hemminger
On Wed, 8 Jul 2020 15:38:02 +0300 Anton Danilov wrote: > The option 'nocase' allows ignore case in the pattern matching. > > Examples: > nstat --nocase *drop* > nstat -azi icmp* > > Signed-off-by: Anton Danilov On second thought, this looks like a good idea. Perhaps it should also be

Re: [PATCH iproute2] nstat: case-insensitive pattern matching

2020-07-08 Thread Stephen Hemminger
On Wed, 8 Jul 2020 15:38:02 +0300 Anton Danilov wrote: > The option 'nocase' allows ignore case in the pattern matching. > > Examples: > nstat --nocase *drop* > nstat -azi icmp* > > Signed-off-by: Anton Danilov Why not just make it the default? I can't imagine a scenario where user w

[PATCH iproute2] nstat: case-insensitive pattern matching

2020-07-08 Thread Anton Danilov
The option 'nocase' allows ignore case in the pattern matching. Examples: nstat --nocase *drop* nstat -azi icmp* Signed-off-by: Anton Danilov --- man/man8/rtacct.8 | 8 +++- misc/nstat.c | 14 ++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/man/m