Re: [PATCH iproute2] ip vrf: Add command name next to pid

2017-04-14 Thread David Ahern
On 4/14/17 4:57 PM, Stephen Hemminger wrote: > Overall, this looks like a good idea. > >> + >> +int get_comm(char *pid, char *comm, int len) > > > Please use more glibc style function signature, like: > > int get_comm(const char *pid, char *comm, size_t len) > > And maybe even > int get_comman

Re: [PATCH iproute2] ip vrf: Add command name next to pid

2017-04-14 Thread Stephen Hemminger
Overall, this looks like a good idea. > + > +int get_comm(char *pid, char *comm, int len) Please use more glibc style function signature, like: int get_comm(const char *pid, char *comm, size_t len) And maybe even int get_command_name(pid_t pid, char *comm, size_t len)

[PATCH iproute2] ip vrf: Add command name next to pid

2017-04-12 Thread David Ahern
'ip vrf pids' is used to list processes bound to a vrf, but it only shows the pid leaving a lot of work for the user. Add the command name to the output. With this patch you get the more user friendly: $ ip vrf pids mgmt 1121 ntpd 1418 gdm-session-wor 1488 gnome-session