Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2020-05-06 Thread David Ahern
On 5/17/18 4:36 PM, Stephen Hemminger wrote: > On Thu, 17 May 2018 16:22:37 -0600 > dsah...@kernel.org wrote: > >> From: David Ahern >> >> Using iproute2 to create a bridge and add 4094 vlans to it can take from >> 2 to 3 *minutes*. The reason is the extraneous call to ll_name_to_index. >> ll_nam

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-25 Thread Stephen Hemminger
On Fri, 18 May 2018 17:40:05 -0600 David Ahern wrote: > On 5/18/18 4:08 PM, Stephen Hemminger wrote: > > > > What about just pushing the lookup down to the leaf functions that need it? > > > > That should work as well. You want to re-send a formal patch? > I just pushed it up as a formal p

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-18 Thread David Ahern
On 5/18/18 4:08 PM, Stephen Hemminger wrote: > > What about just pushing the lookup down to the leaf functions that need it? > That should work as well. You want to re-send a formal patch?

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-18 Thread Stephen Hemminger
On Thu, 17 May 2018 18:17:12 -0600 David Ahern wrote: > On 5/17/18 4:36 PM, Stephen Hemminger wrote: > > On Thu, 17 May 2018 16:22:37 -0600 > > dsah...@kernel.org wrote: > > > >> From: David Ahern > >> > >> Using iproute2 to create a bridge and add 4094 vlans to it can take from > >> 2 to 3 *

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-17 Thread David Ahern
On 5/17/18 4:36 PM, Stephen Hemminger wrote: > On Thu, 17 May 2018 16:22:37 -0600 > dsah...@kernel.org wrote: > >> From: David Ahern >> >> Using iproute2 to create a bridge and add 4094 vlans to it can take from >> 2 to 3 *minutes*. The reason is the extraneous call to ll_name_to_index. >> ll_nam

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-17 Thread Stephen Hemminger
On Thu, 17 May 2018 16:22:37 -0600 dsah...@kernel.org wrote: > From: David Ahern > > Using iproute2 to create a bridge and add 4094 vlans to it can take from > 2 to 3 *minutes*. The reason is the extraneous call to ll_name_to_index. > ll_name_to_index results in an ioctl(SIOCGIFINDEX) call which

[PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-17 Thread dsahern
From: David Ahern Using iproute2 to create a bridge and add 4094 vlans to it can take from 2 to 3 *minutes*. The reason is the extraneous call to ll_name_to_index. ll_name_to_index results in an ioctl(SIOCGIFINDEX) call which in turn invokes dev_load. If the index does not exist, which it won't w