Re: [PATCH iproute2] ip: replace exit with return

2015-08-19 Thread Stephen Hemminger
On Tue, 11 Aug 2015 09:40:23 + Zhang Shengju wrote: > In our manual, we have this description of 'EXIT STATUS': > Exit status is 0 if command was successful, and 1 if there is a syntax > error. > > But we exit in command functions with code -1 when there is a syntax error. > It's better to u

RE: [PATCH iproute2] ip: replace exit with return

2015-08-12 Thread 张胜举
> > From: netdev-ow...@vger.kernel.org > > Sent: 11 August 2015 10:40 > > In our manual, we have this description of 'EXIT STATUS': > > Exit status is 0 if command was successful, and 1 if there is a syntax > > error. > > > > But we exit in command functions with code -1 when there is a syntax err

RE: [PATCH iproute2] ip: replace exit with return

2015-08-12 Thread David Laight
From: netdev-ow...@vger.kernel.org > Sent: 11 August 2015 10:40 > In our manual, we have this description of 'EXIT STATUS': > Exit status is 0 if command was successful, and 1 if there is a syntax > error. > > But we exit in command functions with code -1 when there is a syntax error. > It's bette

[PATCH iproute2] ip: replace exit with return

2015-08-11 Thread Zhang Shengju
In our manual, we have this description of 'EXIT STATUS': Exit status is 0 if command was successful, and 1 if there is a syntax error. But we exit in command functions with code -1 when there is a syntax error. It's better to use return. Signed-off-by: Zhang Shengju --- ip/ipaddress.c | 2 +-