Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-19 Thread David Ahern
On 1/19/18 3:40 PM, Stephen Hemminger wrote: >> mnl_attr_type_valid calls mnl_attr_get_type which does attr->nla_type & >> NLA_TYPE_MASK. Since you are no longer acknowledging the return code of >> mnl_attr_type_valid, you don't care about its checks so you might as >> well not call it. I don't see

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-19 Thread Stephen Hemminger
On Fri, 19 Jan 2018 14:27:06 -0800 David Ahern wrote: > On 1/19/18 2:02 PM, Stephen Hemminger wrote: > > On Thu, 18 Jan 2018 20:42:44 -0800 > > David Ahern wrote: > > > >> On 1/17/18 5:28 AM, Arkadi Sharshevsky wrote: > >>> In case of extending the UAPI old packages would break. > >>> > >>>

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-19 Thread David Ahern
On 1/19/18 2:02 PM, Stephen Hemminger wrote: > On Thu, 18 Jan 2018 20:42:44 -0800 > David Ahern wrote: > >> On 1/17/18 5:28 AM, Arkadi Sharshevsky wrote: >>> In case of extending the UAPI old packages would break. >>> >>> Signed-off-by: Arkadi Sharshevsky >>> --- >>> devlink/devlink.c | 2 +- >>

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-19 Thread Stephen Hemminger
On Thu, 18 Jan 2018 20:42:44 -0800 David Ahern wrote: > On 1/17/18 5:28 AM, Arkadi Sharshevsky wrote: > > In case of extending the UAPI old packages would break. > > > > Signed-off-by: Arkadi Sharshevsky > > --- > > devlink/devlink.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-18 Thread David Ahern
On 1/17/18 5:28 AM, Arkadi Sharshevsky wrote: > In case of extending the UAPI old packages would break. > > Signed-off-by: Arkadi Sharshevsky > --- > devlink/devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devlink/devlink.c b/devlink/devlink.c > index 39cda06.

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-18 Thread Stephen Hemminger
On Wed, 17 Jan 2018 15:28:00 +0200 Arkadi Sharshevsky wrote: > In case of extending the UAPI old packages would break. > > Signed-off-by: Arkadi Sharshevsky Looks like good future proofing. Applied.

Re: [PATCH iproute2] devlink: Ignore unknown attributes

2018-01-17 Thread Jiri Pirko
Wed, Jan 17, 2018 at 02:28:00PM CET, arka...@mellanox.com wrote: >In case of extending the UAPI old packages would break. > >Signed-off-by: Arkadi Sharshevsky Acked-by: Jiri Pirko

[PATCH iproute2] devlink: Ignore unknown attributes

2018-01-17 Thread Arkadi Sharshevsky
In case of extending the UAPI old packages would break. Signed-off-by: Arkadi Sharshevsky --- devlink/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 39cda06..c9d1838 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c