Re: [PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

2017-01-16 Thread Leon Romanovsky
On Mon, Jan 16, 2017 at 01:38:40PM +0530, Selvin Xavier wrote: > On Mon, Jan 16, 2017 at 1:11 AM, Leon Romanovsky wrote: > > Recently, in one of our submission to netdev and rdma, we got > > a reminder that inline functions shouldn't be in *.c. Let for > > the compiler to decide. > > > > IMHO, it

Re: [PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

2017-01-16 Thread Selvin Xavier
On Mon, Jan 16, 2017 at 1:11 AM, Leon Romanovsky wrote: > Recently, in one of our submission to netdev and rdma, we got > a reminder that inline functions shouldn't be in *.c. Let for > the compiler to decide. > > IMHO, it should be open-coded without wrappers and honestly I failed to > understand

Re: [PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

2017-01-15 Thread Leon Romanovsky
On Tue, Dec 20, 2016 at 01:13:13AM -0800, Selvin Xavier wrote: > This patch handles the registration with the bnxt_en driver. > The bnxt_re driver first registers with netdev notifier chain and upon > receiving the NETDEV_REGISTER event, it registers with bnxt_en driver. > > 1. bnxt_en's ulp_

[PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

2016-12-20 Thread Selvin Xavier
This patch handles the registration with the bnxt_en driver. The bnxt_re driver first registers with netdev notifier chain and upon receiving the NETDEV_REGISTER event, it registers with bnxt_en driver. 1. bnxt_en's ulp_probe function returns a structure that contains informatio