Re: [PATCH for-next V1 1/2] net/mlx5: Fix mlx5 ifc cmd_hca_cap bad offsets

2016-04-13 Thread Saeed Mahameed
On Wed, Apr 13, 2016 at 8:48 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2016 at 07:11:03PM +0300, Saeed Mahameed wrote: > >> Fixes: b084590e ("net/mlx5_core: Introduce access function to read >> internal timer ") >> Fixes: b4ff3a36d3e4 ("net/mlx5: Use offset based reserved field names in th

Re: [PATCH for-next V1 1/2] net/mlx5: Fix mlx5 ifc cmd_hca_cap bad offsets

2016-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2016 at 07:11:03PM +0300, Saeed Mahameed wrote: > Fixes: b084590e ("net/mlx5_core: Introduce access function to read > internal timer ") > Fixes: b4ff3a36d3e4 ("net/mlx5: Use offset based reserved field names in the > IFC header file") Are you sure those are right? b0845

[PATCH for-next V1 1/2] net/mlx5: Fix mlx5 ifc cmd_hca_cap bad offsets

2016-04-13 Thread Saeed Mahameed
From: Tariq Toukan All reserved fields after early_vf_enable are off by 1, since early_vf_enable was not explicitly declared as array of size 1. Reserved field before cqe_zip had a wrong size, it should be 0x80 + 0x3f. Fixes: b084590e ("net/mlx5_core: Introduce access function to read inter