Re: [PATCH for-next 1/4] devlink: refactor validation of finding required arguments

2019-02-11 Thread Jiri Pirko
Sun, Feb 10, 2019 at 07:28:46PM CET, a...@mellanox.com wrote: >Introducing argument's metadata structure matching a bitmap flag per >required argument and an error message if missing. Using this static >array to refactor validation of finding required arguments in devlink >command line and to ease

Re: [PATCH for-next 1/4] devlink: refactor validation of finding required arguments

2019-02-10 Thread David Ahern
On 2/10/19 11:28 AM, Aya Levin wrote: > @@ -950,6 +951,51 @@ static int param_cmode_get(const char *cmodestr, > return 0; > } > > +struct dl_args_metadata { > + uint32_t o_flag; > + char err_msg[DL_ARGS_REQUIRED_MAX_ERR_LEN]; > +}; > + > +static const struct dl_args_metadata dl_arg

[PATCH for-next 1/4] devlink: refactor validation of finding required arguments

2019-02-10 Thread Aya Levin
Introducing argument's metadata structure matching a bitmap flag per required argument and an error message if missing. Using this static array to refactor validation of finding required arguments in devlink command line and to ease further maintenance. Signed-off-by: Aya Levin Reviewed-by: Moshe