Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Oleksij Rempel
On Tue, Jun 09, 2020 at 02:48:51PM -0700, Dan Williams wrote: > On Tue, Jun 9, 2020 at 12:57 PM David Miller wrote: > > > > From: "Williams, Dan J" > > Date: Tue, 9 Jun 2020 19:30:50 + > > > > > On Tue, 2020-06-09 at 11:36 -0700, David Miller wrote: > > >> From: Stephen Hemminger > > >> Date

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Dan Williams
On Tue, Jun 9, 2020 at 12:57 PM David Miller wrote: > > From: "Williams, Dan J" > Date: Tue, 9 Jun 2020 19:30:50 + > > > On Tue, 2020-06-09 at 11:36 -0700, David Miller wrote: > >> From: Stephen Hemminger > >> Date: Tue, 9 Jun 2020 10:19:35 -0700 > >> > >> > Yes, words do matter and convey a

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Kees Cook
On Tue, Jun 09, 2020 at 10:53:03PM +0200, Michal Kubecek wrote: > The same IMHO holds for your example with register states or names: > I believe it is highly beneficial to make them consistent with technical > documentation. There are even cases where we violate kernel coding style > (e.g. by usin

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Michal Kubecek
On Tue, Jun 09, 2020 at 01:29:42PM -0700, Kees Cook wrote: > On Tue, Jun 09, 2020 at 01:05:17PM -0700, David Miller wrote: > > From: Kees Cook > > Date: Tue, 9 Jun 2020 12:49:48 -0700 > > > > > Okay, for now, how about: > > > > > > - If we're dealing with an existing spec, match the language. >

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Michal Kubecek
On Tue, Jun 09, 2020 at 10:19:35AM -0700, Stephen Hemminger wrote: > On Sun, 07 Jun 2020 16:45:32 -0700 (PDT) > David Miller wrote: > > > From: Stephen Hemminger > > Date: Sun, 7 Jun 2020 15:30:19 -0700 > > > > > Open source projects have been working hard to remove the terms master > > > and

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Kees Cook
On Tue, Jun 09, 2020 at 01:05:17PM -0700, David Miller wrote: > From: Kees Cook > Date: Tue, 9 Jun 2020 12:49:48 -0700 > > > Okay, for now, how about: > > > > - If we're dealing with an existing spec, match the language. > > Yes. > > > - If we're dealing with a new spec, ask the authors to fix

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread David Miller
From: Kees Cook Date: Tue, 9 Jun 2020 12:49:48 -0700 > Okay, for now, how about: > > - If we're dealing with an existing spec, match the language. Yes. > - If we're dealing with a new spec, ask the authors to fix their language. Please be more specific about "new", if it's a passed and ratifi

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Kees Cook
On Tue, Jun 09, 2020 at 12:34:37PM -0700, David Miller wrote: > From: Kees Cook > Date: Tue, 9 Jun 2020 12:29:54 -0700 > > > Given what I've seen from other communities and what I know of the kernel > > community, I don't think we're going to get consensus on some massive > > global search/replac

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread David Miller
From: "Williams, Dan J" Date: Tue, 9 Jun 2020 19:30:50 + > On Tue, 2020-06-09 at 11:36 -0700, David Miller wrote: >> From: Stephen Hemminger >> Date: Tue, 9 Jun 2020 10:19:35 -0700 >> >> > Yes, words do matter and convey a lot of implied connotation and >> > meaning. >> >> What is your lon

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread David Miller
From: Kees Cook Date: Tue, 9 Jun 2020 12:29:54 -0700 > Given what I've seen from other communities and what I know of the kernel > community, I don't think we're going to get consensus on some massive > global search/replace any time soon. However, I think we can get started > on making this chan

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Williams, Dan J
On Tue, 2020-06-09 at 11:36 -0700, David Miller wrote: > From: Stephen Hemminger > Date: Tue, 9 Jun 2020 10:19:35 -0700 > > > Yes, words do matter and convey a lot of implied connotation and > > meaning. > > What is your long term plan? Will you change all of the UAPI for > bonding for example?

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Kees Cook
On Tue, Jun 09, 2020 at 11:36:33AM -0700, David Miller wrote: > From: Stephen Hemminger > Date: Tue, 9 Jun 2020 10:19:35 -0700 > > > Yes, words do matter and convey a lot of implied connotation and > > meaning. > > What is your long term plan? Will you change all of the UAPI for > bonding for e

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Edward Cree
Disclaimer: *definitely* not speaking for my employer. On 09/06/2020 18:19, Stephen Hemminger wrote: > How many times have you or Linus argued about variable naming. > Yes, words do matter and convey a lot of implied connotation and meaning. Connotation, unlike denotation, is widely variable. I w

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread David Miller
From: Stephen Hemminger Date: Tue, 9 Jun 2020 10:19:35 -0700 > Yes, words do matter and convey a lot of implied connotation and > meaning. What is your long term plan? Will you change all of the UAPI for bonding for example? Or will we have a partial solution to the problem?

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Andrew Lunn
Hi Stephen > A common example is that master/slave is unclear and would be clearer > as primary/secondary or active/backup or controller/worker. 802.3, cause 32.1.2, 2015 version: A 100BASE-T2 PHY can be configured either as a master PHY or as a slave PHY. The master-slave relationship bet

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Stephen Hemminger
On Sun, 07 Jun 2020 16:45:32 -0700 (PDT) David Miller wrote: > From: Stephen Hemminger > Date: Sun, 7 Jun 2020 15:30:19 -0700 > > > Open source projects have been working hard to remove the terms master and > > slave > > in API's and documentation. Apparently, Linux hasn't gotten the message.

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-07 Thread David Miller
From: Stephen Hemminger Date: Sun, 7 Jun 2020 15:30:19 -0700 > Open source projects have been working hard to remove the terms master and > slave > in API's and documentation. Apparently, Linux hasn't gotten the message. > It would make sense not to introduce new instances. Would you also be ag

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-07 Thread Stephen Hemminger
On Tue, 26 May 2020 11:10:25 +0200 Oleksij Rempel wrote: > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > auto-negotiation support, we needed to be able to configure the > MASTER-SLAVE role of the port manually or from an application in user > space. > > The same UAPI

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-05-27 Thread Oleksij Rempel
On Tue, May 26, 2020 at 02:41:39PM +0200, Michal Kubecek wrote: > On Tue, May 26, 2020 at 11:10:25AM +0200, Oleksij Rempel wrote: > > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > > auto-negotiation support, we needed to be able to configure the > > MASTER-SLAVE role of

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-05-26 Thread Michal Kubecek
On Tue, May 26, 2020 at 11:10:25AM +0200, Oleksij Rempel wrote: > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > auto-negotiation support, we needed to be able to configure the > MASTER-SLAVE role of the port manually or from an application in user > space. > > The same

[PATCH ethtool v1] netlink: add master/slave configuration support

2020-05-26 Thread Oleksij Rempel
This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of auto-negotiation support, we needed to be able to configure the MASTER-SLAVE role of the port manually or from an application in user space. The same UAPI can be used for 1000BASE-T or MultiGBASE-T devices to force MASTER or S