Re: [PATCH ethtool 2/7] ioctl: check presence of eeprom length argument properly

2020-08-10 Thread Andrew Lunn
On Sun, Aug 09, 2020 at 11:24:22PM +0200, Michal Kubecek wrote: > In do_geeprom(), do_seprom() and do_getmodule(), check if user used > "length" command line argument is done by setting the value to -1 before > parsing and checking if it changed. This is quite ugly and also causes > compiler warnin

[PATCH ethtool 2/7] ioctl: check presence of eeprom length argument properly

2020-08-09 Thread Michal Kubecek
In do_geeprom(), do_seprom() and do_getmodule(), check if user used "length" command line argument is done by setting the value to -1 before parsing and checking if it changed. This is quite ugly and also causes compiler warnings as the variable is u32. Use proper "seen" flag to let parser tell us