Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-09 Thread Michal Kubecek
On Fri, Aug 09, 2019 at 12:23:36PM -0400, John W. Linville wrote: > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > Usually kernel drivers set the regs->len value to the same length as > > info->regdump_len, which was used for the allocation. In case where > > regs->len is small

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-09 Thread John W. Linville
On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > Usually kernel drivers set the regs->len value to the same length as > info->regdump_len, which was used for the allocation. In case where > regs->len is smaller than the allocated info->regdump_len length, > we may assume that the d

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-06 Thread Jiri Pirko
Tue, Aug 06, 2019 at 07:20:02AM CEST, mkube...@suse.cz wrote: >On Mon, Aug 05, 2019 at 10:52:16AM -0400, Vivien Didelot wrote: >> Hi Michal! >> >> On Mon, 5 Aug 2019 10:04:48 +0200, Michal Kubecek wrote: >> > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: >> > > Usually kernel dr

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-06 Thread Vivien Didelot
Hi Michal, On Tue, 6 Aug 2019 07:20:02 +0200, Michal Kubecek wrote: > On Mon, Aug 05, 2019 at 10:52:16AM -0400, Vivien Didelot wrote: > > Hi Michal! > > > > On Mon, 5 Aug 2019 10:04:48 +0200, Michal Kubecek wrote: > > > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > > > Usu

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-05 Thread Michal Kubecek
On Mon, Aug 05, 2019 at 10:52:16AM -0400, Vivien Didelot wrote: > Hi Michal! > > On Mon, 5 Aug 2019 10:04:48 +0200, Michal Kubecek wrote: > > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > > Usually kernel drivers set the regs->len value to the same length as > > > info->regd

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-05 Thread Vivien Didelot
Hi Michal! On Mon, 5 Aug 2019 10:04:48 +0200, Michal Kubecek wrote: > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > Usually kernel drivers set the regs->len value to the same length as > > info->regdump_len, which was used for the allocation. In case where > > regs->len is s

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-05 Thread Michal Kubecek
On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > Usually kernel drivers set the regs->len value to the same length as > info->regdump_len, which was used for the allocation. In case where > regs->len is smaller than the allocated info->regdump_len length, > we may assume that the d

[PATCH ethtool] ethtool: dump nested registers

2019-08-02 Thread Vivien Didelot
Usually kernel drivers set the regs->len value to the same length as info->regdump_len, which was used for the allocation. In case where regs->len is smaller than the allocated info->regdump_len length, we may assume that the dump contains a nested set of registers. This becomes handy for kernel d