Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-22 Thread Vasundhara Volam
On Tue, Sep 22, 2020 at 12:22 PM Michal Kubecek wrote: > > On Tue, Sep 22, 2020 at 11:24:24AM +0530, Vasundhara Volam wrote: > > On Mon, Sep 21, 2020 at 2:48 PM Michal Kubecek wrote: > > > > + return -1; > > > > + } > > > > + > > > > + pcie_stats = (u16 *)(regs->data + BNXT_PX

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Michal Kubecek
On Tue, Sep 22, 2020 at 11:24:24AM +0530, Vasundhara Volam wrote: > On Mon, Sep 21, 2020 at 2:48 PM Michal Kubecek wrote: > > > + return -1; > > > + } > > > + > > > + pcie_stats = (u16 *)(regs->data + BNXT_PXP_REG_LEN); > > > + fprintf(stdout, "PCIe statistics:\n"); > > > +

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Vasundhara Volam
On Mon, Sep 21, 2020 at 6:11 PM Andrew Lunn wrote: > > > +struct bnxt_pcie_stat { > > + const char *name; > > + u16 offset; > > + u8 size; > > + const char *format; > > +}; > > + > > +static const struct bnxt_pcie_stat bnxt_pcie_stats[] = { > > + { .name = "PL Signal integrity

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Vasundhara Volam
On Mon, Sep 21, 2020 at 2:48 PM Michal Kubecek wrote: > > On Mon, Sep 21, 2020 at 12:09:51PM +0530, Vasundhara Volam wrote: > > This patch adds the initial support for parsing registers dumped > > by the Broadcom driver. Currently, PXP and PCIe registers are > > parsed. > > > > Reviewed-by: Andy G

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Andrew Lunn
> +struct bnxt_pcie_stat { > + const char *name; > + u16 offset; > + u8 size; > + const char *format; > +}; > + > +static const struct bnxt_pcie_stat bnxt_pcie_stats[] = { > + { .name = "PL Signal integrity errors ", .offset = 0, .size = 4, > .format = "%lld" }, > + { .

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Michal Kubecek
On Mon, Sep 21, 2020 at 12:09:51PM +0530, Vasundhara Volam wrote: > This patch adds the initial support for parsing registers dumped > by the Broadcom driver. Currently, PXP and PCIe registers are > parsed. > > Reviewed-by: Andy Gospodarek > Reviewed-by: Edwin Peer > Signed-off-by: Vasundhara Vo

[PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-20 Thread Vasundhara Volam
This patch adds the initial support for parsing registers dumped by the Broadcom driver. Currently, PXP and PCIe registers are parsed. Reviewed-by: Andy Gospodarek Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam --- Makefile.am | 2 +- bnxt.c | 86