Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-05 Thread Michael Buesch
On Saturday 05 August 2006 19:30, Michael Buesch wrote: > On Saturday 05 August 2006 13:46, Christoph Hellwig wrote: > > On Tue, Aug 01, 2006 at 08:21:49AM -0400, John W. Linville wrote: > > > I don't anticipate the d80211 naming conventions to ever make it out > > > of wireless-dev. By the time w

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-05 Thread Michael Buesch
On Saturday 05 August 2006 13:46, Christoph Hellwig wrote: > On Tue, Aug 01, 2006 at 08:21:49AM -0400, John W. Linville wrote: > > I don't anticipate the d80211 naming conventions to ever make it out > > of wireless-dev. By the time we are ready to push that stuff upstream, > > we will have cleane

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-05 Thread Christoph Hellwig
On Tue, Aug 01, 2006 at 08:21:49AM -0400, John W. Linville wrote: > I don't anticipate the d80211 naming conventions to ever make it out > of wireless-dev. By the time we are ready to push that stuff upstream, > we will have cleaned-up our messes. Yes, absolutely. > This does raise the question:

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Ulrich Kunitz
On 06-08-01 15:58 Jiri Benc wrote: > > pointing non-migrated drivers (ipw2[12]00, zd1211rw) at the old > > code, > > Yes. Rather than moving, zd1211 should be ported to d80211 - this will > also allow using of more advanced features of the hw. I have currently no idea, when this will happen. Cur

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Ivo van Doorn
On Tuesday 01 August 2006 19:11, John W. Linville wrote: > On Tue, Aug 01, 2006 at 04:25:05PM +0200, Ivo Van Doorn wrote: > > Hi, > > > > >> Do you have a plan when you will merge rt2x00 patches so I can apply > > >> Michael's renaming patch(es) without risk of conflicts? > > > > > >Working on it

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread John W. Linville
On Tue, Aug 01, 2006 at 04:25:05PM +0200, Ivo Van Doorn wrote: > Hi, > > >> Do you have a plan when you will merge rt2x00 patches so I can apply > >> Michael's renaming patch(es) without risk of conflicts? > > > >Working on it ~now. I hit a snag in that Ivo's patches seem to rely on > >his radio

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Ivo Van Doorn
Hi, > Do you have a plan when you will merge rt2x00 patches so I can apply > Michael's renaming patch(es) without risk of conflicts? Working on it ~now. I hit a snag in that Ivo's patches seem to rely on his radio button patch, which I had ignored until now. I'll probably pull that in this mo

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread John W. Linville
On Tue, Aug 01, 2006 at 03:58:37PM +0200, Jiri Benc wrote: > Do you have a plan when you will merge rt2x00 patches so I can apply > Michael's renaming patch(es) without risk of conflicts? Working on it ~now. I hit a snag in that Ivo's patches seem to rely on his radio button patch, which I had i

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Jiri Benc
> On Tue, Aug 01, 2006 at 10:56:50AM +0100, Christoph Hellwig wrote: > > NACK again. Driver should continue to use the ieee80211.h header forever. When a patch that renames constants in d80211 is merged and d80211 stack is moved to ieee80211/ directory, there will be only slight changes (if any)

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread John W. Linville
On Tue, Aug 01, 2006 at 10:56:50AM +0100, Christoph Hellwig wrote: > On Mon, Jul 31, 2006 at 01:51:31PM -0700, Michael Wu wrote: > > On Monday 31 July 2006 13:31, John W. Linville wrote: > > > As usual I'll depend on Jiri to merge d80211 stack patches, then > > > send me a pull request. If I apply

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Christoph Hellwig
On Mon, Jul 31, 2006 at 01:51:31PM -0700, Michael Wu wrote: > On Monday 31 July 2006 13:31, John W. Linville wrote: > > As usual I'll depend on Jiri to merge d80211 stack patches, then > > send me a pull request. If I apply your "Switch drivers to d80211" > > series now, that will undoutedly cause

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-31 Thread Michael Wu
On Monday 31 July 2006 13:31, John W. Linville wrote: > As usual I'll depend on Jiri to merge d80211 stack patches, then > send me a pull request. If I apply your "Switch drivers to d80211" > series now, that will undoutedly cause a breakage when Jiri asks me > to pull this later. > Yeah, there ne

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-31 Thread John W. Linville
On Thu, Jul 27, 2006 at 12:37:14AM -0700, Michael Wu wrote: > Alright, I've replaced all + lines with spaces with tabs. > > I also fixed one long line. The rest of them are nearly impossible to shorten > well. The "(fc & IEEE80211_FCTL_FTYPE) == IEEE80211_FTYPE_DATA" style is > really killing us

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-27 Thread Michael Wu
Alright, I've replaced all + lines with spaces with tabs. I also fixed one long line. The rest of them are nearly impossible to shorten well. The "(fc & IEEE80211_FCTL_FTYPE) == IEEE80211_FTYPE_DATA" style is really killing us (unless you want to break after ==, which is rather bad). I think we

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Michael Wu
On Wednesday 26 July 2006 09:53, Jiri Benc wrote: > I just meant running some s/ {8}/\t/ on your patch :-) > > Also, I don't want to fix all of tab issues in d80211 by one big patch. > I always have several patches pending (and other people probably too) > and it leads to unnecessary rejects when a

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Jiri Benc
On Wed, 26 Jul 2006 09:43:55 -0700, Michael Wu wrote: > I still want to convert d80211_mgmt.h. Once that's done, I'll look through > for > those tabs/spaces & long lines formatting issues. I won't mind if you start > fixing some of those issues now, however. :) I just meant running some s/ {8}/

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Michael Wu
On Wednesday 26 July 2006 09:32, Jiri Benc wrote: > One more thing (hopefully the last one), could you try to keep lines > under 80 characters? I understand that with such long identifiers it is > not always possible (it dramatically reduces readability of the code if > you try to force the limit i

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Jiri Benc
On Mon, 24 Jul 2006 23:02:50 -0700, Michael Wu wrote: > These two attached patches also roll in a switch to MAC_FMT and MAC_ARG, and > use IEEE80211_DATA_LEN when possible. Otherwise, it's the same as before > except split into two patches. Nice, thanks a lot. One more thing (hopefully the last

[PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-24 Thread Michael Wu
Big patches are fun. These two attached patches also roll in a switch to MAC_FMT and MAC_ARG, and use IEEE80211_DATA_LEN when possible. Otherwise, it's the same as before except split into two patches. Thanks, -Michael Wu switch-d80211-to-new-names.bz2 Description: BZip2 compressed data swi