Re: [PATCH bpf v4] xsk: do not discard packet when NETDEV_TX_BUSY

2020-09-15 Thread Daniel Borkmann
Hey Magnus, On 9/11/20 2:43 PM, Magnus Karlsson wrote: From: Magnus Karlsson In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When NETDEV_TX_BUSY is set in the drivers, it signifies that it was not possible to send the packet right now, please try later. Unfort

Re: [PATCH bpf v4] xsk: do not discard packet when NETDEV_TX_BUSY

2020-09-15 Thread Magnus Karlsson
On Tue, Sep 15, 2020 at 5:49 PM Daniel Borkmann wrote: > > Hey Magnus, > > On 9/11/20 2:43 PM, Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > In the skb Tx path, transmission of a packet is performed with > > dev_direct_xmit(). When NETDEV_TX_BUSY is set in the drivers, it > > signifies

Re: [PATCH bpf v4] xsk: do not discard packet when NETDEV_TX_BUSY

2020-09-14 Thread Jesse Brandeburg
Magnus Karlsson wrote: > From: Magnus Karlsson > > In the skb Tx path, transmission of a packet is performed with > dev_direct_xmit(). When NETDEV_TX_BUSY is set in the drivers, it > signifies that it was not possible to send the packet right now, > please try later. Unfortunately, the xsk trans

[PATCH bpf v4] xsk: do not discard packet when NETDEV_TX_BUSY

2020-09-11 Thread Magnus Karlsson
From: Magnus Karlsson In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When NETDEV_TX_BUSY is set in the drivers, it signifies that it was not possible to send the packet right now, please try later. Unfortunately, the xsk transmit code discarded the packet and re