Re: [PATCH bpf v3] libbpf: handle symbol versioning properly for libbpf.a

2019-09-30 Thread Alexei Starovoitov
On 9/30/19 9:56 AM, Yonghong Song wrote: > > > On 9/30/19 9:42 AM, Alexei Starovoitov wrote: >> On 9/30/19 9:29 AM, Yonghong Song wrote: >>> +OLD_VERSION(xsk_umem__create_v0_0_2, xsk_umem__create, LIBBPF_0.0.2) >>> +NEW_VERSION(xsk_umem__create_v0_0_4, xsk_umem__create, LIBBPF_0.0.4) >> >> how th

Re: [PATCH bpf v3] libbpf: handle symbol versioning properly for libbpf.a

2019-09-30 Thread Yonghong Song
On 9/30/19 9:42 AM, Alexei Starovoitov wrote: > On 9/30/19 9:29 AM, Yonghong Song wrote: >> +OLD_VERSION(xsk_umem__create_v0_0_2, xsk_umem__create, LIBBPF_0.0.2) >> +NEW_VERSION(xsk_umem__create_v0_0_4, xsk_umem__create, LIBBPF_0.0.4) > > how this will look when yet another version of this funct

Re: [PATCH bpf v3] libbpf: handle symbol versioning properly for libbpf.a

2019-09-30 Thread Alexei Starovoitov
On 9/30/19 9:29 AM, Yonghong Song wrote: > +OLD_VERSION(xsk_umem__create_v0_0_2, xsk_umem__create, LIBBPF_0.0.2) > +NEW_VERSION(xsk_umem__create_v0_0_4, xsk_umem__create, LIBBPF_0.0.4) how this will look when yet another version of this function is introduced, say in 0.0.6 ? OLD_VERSION(xsk_umem

[PATCH bpf v3] libbpf: handle symbol versioning properly for libbpf.a

2019-09-30 Thread Yonghong Song
bcc uses libbpf repo as a submodule. It brings in libbpf source code and builds everything together to produce shared libraries. With latest libbpf, I got the following errors: /bin/ld: libbcc_bpf.so.0.10.0: version node not found for symbol xsk_umem__create@LIBBPF_0.0.2 /bin/ld: failed to set