Re: [PATCH bpf v2 2/2] libbpf: remove dependency on barrier.h in xsk.h

2019-04-12 Thread Magnus Karlsson
On Thu, Apr 11, 2019 at 10:23 PM Daniel Borkmann wrote: > > On 04/11/2019 09:54 AM, Magnus Karlsson wrote: > > On Wed, Apr 10, 2019 at 9:08 PM Y Song wrote: > >> On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson > >> wrote: > >>> > >>> The use of smp_rmb() and smp_wmb() creates a Linux header dep

Re: [PATCH bpf v2 2/2] libbpf: remove dependency on barrier.h in xsk.h

2019-04-11 Thread Daniel Borkmann
On 04/11/2019 10:23 PM, Daniel Borkmann wrote: > On 04/11/2019 09:54 AM, Magnus Karlsson wrote: >> On Wed, Apr 10, 2019 at 9:08 PM Y Song wrote: >>> On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson >>> wrote: The use of smp_rmb() and smp_wmb() creates a Linux header dependency on b

Re: [PATCH bpf v2 2/2] libbpf: remove dependency on barrier.h in xsk.h

2019-04-11 Thread Daniel Borkmann
On 04/11/2019 09:54 AM, Magnus Karlsson wrote: > On Wed, Apr 10, 2019 at 9:08 PM Y Song wrote: >> On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson >> wrote: >>> >>> The use of smp_rmb() and smp_wmb() creates a Linux header dependency >>> on barrier.h that is uneccessary in most parts. This patch

Re: [PATCH bpf v2 2/2] libbpf: remove dependency on barrier.h in xsk.h

2019-04-11 Thread Magnus Karlsson
On Wed, Apr 10, 2019 at 9:08 PM Y Song wrote: > > On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson > wrote: > > > > The use of smp_rmb() and smp_wmb() creates a Linux header dependency > > on barrier.h that is uneccessary in most parts. This patch implements > > the two small defines that are nee

Re: [PATCH bpf v2 2/2] libbpf: remove dependency on barrier.h in xsk.h

2019-04-10 Thread Y Song
On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson wrote: > > The use of smp_rmb() and smp_wmb() creates a Linux header dependency > on barrier.h that is uneccessary in most parts. This patch implements > the two small defines that are needed from barrier.h. As a bonus, the > new implementations are

[PATCH bpf v2 2/2] libbpf: remove dependency on barrier.h in xsk.h

2019-04-10 Thread Magnus Karlsson
The use of smp_rmb() and smp_wmb() creates a Linux header dependency on barrier.h that is uneccessary in most parts. This patch implements the two small defines that are needed from barrier.h. As a bonus, the new implementations are faster than the default ones as they default to sfence and lfence