Re: [PATCH bpf v2 2/2] bpf: program: refuse non-O_RDWR flags in BPF_OBJ_GET

2021-03-29 Thread Lorenz Bauer
On Fri, 26 Mar 2021 at 20:14, Song Liu wrote: > > On Fri, Mar 26, 2021 at 9:07 AM Lorenz Bauer wrote: > > > > As for bpf_link, refuse creating a non-O_RDWR fd. Since program fds > > currently don't allow modifications this is a precaution, not a > > straight up bug fix. > > > > Signed-off-by: Lor

Re: [PATCH bpf v2 2/2] bpf: program: refuse non-O_RDWR flags in BPF_OBJ_GET

2021-03-27 Thread Andrii Nakryiko
On Fri, Mar 26, 2021 at 1:14 PM Song Liu wrote: > > On Fri, Mar 26, 2021 at 9:07 AM Lorenz Bauer wrote: > > > > As for bpf_link, refuse creating a non-O_RDWR fd. Since program fds > > currently don't allow modifications this is a precaution, not a > > straight up bug fix. > > > > Signed-off-by: L

Re: [PATCH bpf v2 2/2] bpf: program: refuse non-O_RDWR flags in BPF_OBJ_GET

2021-03-26 Thread Song Liu
On Fri, Mar 26, 2021 at 9:07 AM Lorenz Bauer wrote: > > As for bpf_link, refuse creating a non-O_RDWR fd. Since program fds > currently don't allow modifications this is a precaution, not a > straight up bug fix. > > Signed-off-by: Lorenz Bauer > --- > kernel/bpf/inode.c | 2 +- > 1 file changed

[PATCH bpf v2 2/2] bpf: program: refuse non-O_RDWR flags in BPF_OBJ_GET

2021-03-26 Thread Lorenz Bauer
As for bpf_link, refuse creating a non-O_RDWR fd. Since program fds currently don't allow modifications this is a precaution, not a straight up bug fix. Signed-off-by: Lorenz Bauer --- kernel/bpf/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/inode.c b/ker