Re: [PATCH bpf v2 1/2] libbpf: remove likely/unlikely in xsk.h

2019-04-10 Thread Magnus Karlsson
On Wed, Apr 10, 2019 at 9:08 PM Y Song wrote: > > On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson > wrote: > > > > This patch removes the use of likely and unlikely in xsk.h since they > > create a dependency on Linux headers as reported by several > > users. There have also been reports that th

Re: [PATCH bpf v2 1/2] libbpf: remove likely/unlikely in xsk.h

2019-04-10 Thread Y Song
On Wed, Apr 10, 2019 at 12:21 AM Magnus Karlsson wrote: > > This patch removes the use of likely and unlikely in xsk.h since they > create a dependency on Linux headers as reported by several > users. There have also been reports that the use of these decreases > performance as the compiler puts t

[PATCH bpf v2 1/2] libbpf: remove likely/unlikely in xsk.h

2019-04-10 Thread Magnus Karlsson
This patch removes the use of likely and unlikely in xsk.h since they create a dependency on Linux headers as reported by several users. There have also been reports that the use of these decreases performance as the compiler puts the code on two different cache lines instead of on a single one. Al