Re: [PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

On Wed, Jul 15, 2020 at 8:36 PM Daniel Borkmann wrote: > > On 7/11/20 9:39 AM, Magnus Karlsson wrote: > > On Sat, Jul 11, 2020 at 1:28 AM Daniel Borkmann > > wrote: > >> On 7/10/20 8:45 AM, Magnus Karlsson wrote: > >>> In the skb Tx path, transmission of a packet is performed with > >>> dev_dire

Re: [PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

On 7/11/20 9:39 AM, Magnus Karlsson wrote: On Sat, Jul 11, 2020 at 1:28 AM Daniel Borkmann wrote: On 7/10/20 8:45 AM, Magnus Karlsson wrote: In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit routines, it returns NET

Re: [PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

On Sat, Jul 11, 2020 at 09:39:58AM +0200, Magnus Karlsson wrote: > On Sat, Jul 11, 2020 at 1:28 AM Daniel Borkmann wrote: > > > > Hi Magnus, > > > > On 7/10/20 8:45 AM, Magnus Karlsson wrote: > > > In the skb Tx path, transmission of a packet is performed with > > > dev_direct_xmit(). When QUEUE_S

Re: [PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

On Sat, Jul 11, 2020 at 1:28 AM Daniel Borkmann wrote: > > Hi Magnus, > > On 7/10/20 8:45 AM, Magnus Karlsson wrote: > > In the skb Tx path, transmission of a packet is performed with > > dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit > > routines, it returns NETDEV_TX_BUSY sign

Re: [PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

Hi Magnus, On 7/10/20 8:45 AM, Magnus Karlsson wrote: In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit routines, it returns NETDEV_TX_BUSY signifying that it was not possible to send the packet now, please try later.

Re: [PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

On Fri, Jul 10, 2020 at 08:45:54AM +0200, Magnus Karlsson wrote: > In the skb Tx path, transmission of a packet is performed with > dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit > routines, it returns NETDEV_TX_BUSY signifying that it was not > possible to send the packet now, p

[PATCH bpf v2] xsk: fix memory leak and packet loss in Tx skb path

In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit routines, it returns NETDEV_TX_BUSY signifying that it was not possible to send the packet now, please try later. Unfortunately, the xsk transmit code discarded the packe