Re: [PATCH bpf 7/7] bpf: make direct packet write unclone more robust

2018-10-24 Thread Song Liu
On Wed, Oct 24, 2018 at 3:08 PM Daniel Borkmann wrote: > > On 10/24/2018 11:42 PM, Song Liu wrote: > > On Wed, Oct 24, 2018 at 1:06 PM Daniel Borkmann > > wrote: > >> > >> Given this seems to be quite fragile and can easily slip through the > >> cracks, lets make direct packet write more robust

Re: [PATCH bpf 7/7] bpf: make direct packet write unclone more robust

2018-10-24 Thread Daniel Borkmann
On 10/24/2018 11:42 PM, Song Liu wrote: > On Wed, Oct 24, 2018 at 1:06 PM Daniel Borkmann wrote: >> >> Given this seems to be quite fragile and can easily slip through the >> cracks, lets make direct packet write more robust by requiring that >> future program types which allow for such write must

Re: [PATCH bpf 7/7] bpf: make direct packet write unclone more robust

2018-10-24 Thread Song Liu
On Wed, Oct 24, 2018 at 1:06 PM Daniel Borkmann wrote: > > Given this seems to be quite fragile and can easily slip through the > cracks, lets make direct packet write more robust by requiring that > future program types which allow for such write must provide a prologue > callback. In case of XDP

[PATCH bpf 7/7] bpf: make direct packet write unclone more robust

2018-10-24 Thread Daniel Borkmann
Given this seems to be quite fragile and can easily slip through the cracks, lets make direct packet write more robust by requiring that future program types which allow for such write must provide a prologue callback. In case of XDP and sk_msg it's noop, thus add a generic noop handler there. The