Re: [PATCH bpf 6/7] bpf: fix leaking uninitialized memory on pop/peek helpers

2018-10-24 Thread Mauricio Vasquez
On 10/24/18 3:05 PM, Daniel Borkmann wrote: Commit f1a2e44a3aec ("bpf: add queue and stack maps") added helpers with ARG_PTR_TO_UNINIT_MAP_VALUE. Meaning, the helper is supposed to fill the map value buffer with data instead of reading from it like in other helpers such as map update. However, gi

[PATCH bpf 6/7] bpf: fix leaking uninitialized memory on pop/peek helpers

2018-10-24 Thread Daniel Borkmann
Commit f1a2e44a3aec ("bpf: add queue and stack maps") added helpers with ARG_PTR_TO_UNINIT_MAP_VALUE. Meaning, the helper is supposed to fill the map value buffer with data instead of reading from it like in other helpers such as map update. However, given the buffer is allowed to be uninitialized