Re: [PATCH bpf 5/7] bpf: fix direct packet write into pop/peek helpers

2018-10-24 Thread Mauricio Vasquez
On 10/24/18 3:05 PM, Daniel Borkmann wrote: Commit f1a2e44a3aec ("bpf: add queue and stack maps") probably just copy-pasted .pkt_access for bpf_map_{pop,peek}_elem() helpers, but this is buggy in this context since it would allow writes into cloned skbs which is invalid. Therefore, disable .pkt

[PATCH bpf 5/7] bpf: fix direct packet write into pop/peek helpers

2018-10-24 Thread Daniel Borkmann
Commit f1a2e44a3aec ("bpf: add queue and stack maps") probably just copy-pasted .pkt_access for bpf_map_{pop,peek}_elem() helpers, but this is buggy in this context since it would allow writes into cloned skbs which is invalid. Therefore, disable .pkt_access for the two. Fixes: f1a2e44a3aec ("bpf: