Re: [PATCH bpf 2/2] bpf: udp: Avoid calling reuseport's bpf_prog from udp_gro

> On Jun 1, 2019, at 6:09 PM, Martin Lau wrote: > > On Sat, Jun 01, 2019 at 04:54:46PM -0700, Song Liu wrote: >> >> >>> On May 31, 2019, at 3:29 PM, Martin KaFai Lau wrote: >>> >>> When the commit a6024562ffd7 ("udp: Add GRO functions to UDP socket") >>> added udp[46]_lib_lookup_skb to the

Re: [PATCH bpf 2/2] bpf: udp: Avoid calling reuseport's bpf_prog from udp_gro

On Sat, Jun 01, 2019 at 04:54:46PM -0700, Song Liu wrote: > > > > On May 31, 2019, at 3:29 PM, Martin KaFai Lau wrote: > > > > When the commit a6024562ffd7 ("udp: Add GRO functions to UDP socket") > > added udp[46]_lib_lookup_skb to the udp_gro code path, it broke > > the reuseport_select_sock(

Re: [PATCH bpf 2/2] bpf: udp: Avoid calling reuseport's bpf_prog from udp_gro

> On May 31, 2019, at 3:29 PM, Martin KaFai Lau wrote: > > When the commit a6024562ffd7 ("udp: Add GRO functions to UDP socket") > added udp[46]_lib_lookup_skb to the udp_gro code path, it broke > the reuseport_select_sock() assumption that skb->data is pointing > to the transport header. > >

[PATCH bpf 2/2] bpf: udp: Avoid calling reuseport's bpf_prog from udp_gro

When the commit a6024562ffd7 ("udp: Add GRO functions to UDP socket") added udp[46]_lib_lookup_skb to the udp_gro code path, it broke the reuseport_select_sock() assumption that skb->data is pointing to the transport header. This patch follows an earlier __udp6_lib_err() fix by passing a NULL skb