Re: [PATCH bpf 1/4] bpf: fix partial copy of map_ptr when dst is scalar

2018-11-01 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 01, 2018 at 07:17:29PM +, Edward Cree escreveu: > On 31/10/18 23:05, Daniel Borkmann wrote: > > ALU operations on pointers such as scalar_reg += map_value_ptr are > > handled in adjust_ptr_min_max_vals(). Problem is however that map_ptr > > and range in the register state share a un

Re: [PATCH bpf 1/4] bpf: fix partial copy of map_ptr when dst is scalar

2018-11-01 Thread Edward Cree
On 31/10/18 23:05, Daniel Borkmann wrote: > ALU operations on pointers such as scalar_reg += map_value_ptr are > handled in adjust_ptr_min_max_vals(). Problem is however that map_ptr > and range in the register state share a union, so transferring state > through dst_reg->range = ptr_reg->range is

[PATCH bpf 1/4] bpf: fix partial copy of map_ptr when dst is scalar

2018-10-31 Thread Daniel Borkmann
ALU operations on pointers such as scalar_reg += map_value_ptr are handled in adjust_ptr_min_max_vals(). Problem is however that map_ptr and range in the register state share a union, so transferring state through dst_reg->range = ptr_reg->range is just buggy as any new map_ptr in the dst_reg is th