Re: [PATCH bpf 0/6] tools: bpftool: fix printf()-like functions

2019-08-16 Thread Jakub Kicinski
On Fri, 16 Aug 2019 10:11:12 -0700, Alexei Starovoitov wrote: > On Fri, Aug 16, 2019 at 9:41 AM Quentin Monnet wrote: > > 2019-08-15 22:08 UTC-0700 ~ Alexei Starovoitov > > > > > On Thu, Aug 15, 2019 at 7:32 AM Quentin Monnet > > > wrote: > > >> > > >> Hi, > > >> Because the "__printf()" attr

Re: [PATCH bpf 0/6] tools: bpftool: fix printf()-like functions

2019-08-16 Thread Quentin Monnet
2019-08-16 10:11 UTC-0700 ~ Alexei Starovoitov > On Fri, Aug 16, 2019 at 9:41 AM Quentin Monnet > wrote: >> >> 2019-08-15 22:08 UTC-0700 ~ Alexei Starovoitov >> >>> On Thu, Aug 15, 2019 at 7:32 AM Quentin Monnet >>> wrote: Hi, Because the "__printf()" attributes were used only wh

Re: [PATCH bpf 0/6] tools: bpftool: fix printf()-like functions

2019-08-16 Thread Alexei Starovoitov
On Fri, Aug 16, 2019 at 9:41 AM Quentin Monnet wrote: > > 2019-08-15 22:08 UTC-0700 ~ Alexei Starovoitov > > > On Thu, Aug 15, 2019 at 7:32 AM Quentin Monnet > > wrote: > >> > >> Hi, > >> Because the "__printf()" attributes were used only where the functions are > >> implemented, and not in head

Re: [PATCH bpf 0/6] tools: bpftool: fix printf()-like functions

2019-08-16 Thread Quentin Monnet
2019-08-15 22:08 UTC-0700 ~ Alexei Starovoitov > On Thu, Aug 15, 2019 at 7:32 AM Quentin Monnet > wrote: >> >> Hi, >> Because the "__printf()" attributes were used only where the functions are >> implemented, and not in header files, the checks have not been enforced on >> all the calls to printf

Re: [PATCH bpf 0/6] tools: bpftool: fix printf()-like functions

2019-08-15 Thread Alexei Starovoitov
On Thu, Aug 15, 2019 at 7:32 AM Quentin Monnet wrote: > > Hi, > Because the "__printf()" attributes were used only where the functions are > implemented, and not in header files, the checks have not been enforced on > all the calls to printf()-like functions, and a number of errors slipped in > bp

[PATCH bpf 0/6] tools: bpftool: fix printf()-like functions

2019-08-15 Thread Quentin Monnet
Hi, Because the "__printf()" attributes were used only where the functions are implemented, and not in header files, the checks have not been enforced on all the calls to printf()-like functions, and a number of errors slipped in bpftool over time. This set cleans up such errors, and then moves th