Re: [PATCH bpf 0/2] libbpf: fixes for AF_XDP teardown

2019-05-04 Thread Alexei Starovoitov
On Tue, Apr 30, 2019 at 8:38 AM Jonathan Lemon wrote: > > > > On 30 Apr 2019, at 5:45, Björn Töpel wrote: > > > William found two bugs, when doing socket teardown within the same > > process. > > > > The first issue was an invalid munmap call, and the second one was an > > invalid XSKMAP cleanup.

Re: [PATCH bpf 0/2] libbpf: fixes for AF_XDP teardown

2019-04-30 Thread Jonathan Lemon
On 30 Apr 2019, at 5:45, Björn Töpel wrote: > William found two bugs, when doing socket teardown within the same > process. > > The first issue was an invalid munmap call, and the second one was an > invalid XSKMAP cleanup. Both resulted in that the process kept > references to the socket, whic

[PATCH bpf 0/2] libbpf: fixes for AF_XDP teardown

2019-04-30 Thread Björn Töpel
William found two bugs, when doing socket teardown within the same process. The first issue was an invalid munmap call, and the second one was an invalid XSKMAP cleanup. Both resulted in that the process kept references to the socket, which was not correctly cleaned up. When a new socket was creat