Re: [PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Sep 22, 2020 at 4:16 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen >> > wrote: >> >> >> >> From: Toke Høiland-Jørgensen >> >> >> >> The check_attach_btf_id() function really d

Re: [PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-22 Thread Andrii Nakryiko
On Tue, Sep 22, 2020 at 4:16 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen > > wrote: > >> > >> From: Toke Høiland-Jørgensen > >> > >> The check_attach_btf_id() function really does three things: > >> > >> 1. It perfor

Re: [PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> The check_attach_btf_id() function really does three things: >> >> 1. It performs a bunch of checks on the program to ensure that the >>attachment is valid. >>

Re: [PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> The check_attach_btf_id() function really does three things: >> >> 1. It performs a bunch of checks on the program to ensure that the >>attachment is valid. >>

Re: [PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > The check_attach_btf_id() function really does three things: > > 1. It performs a bunch of checks on the program to ensure that the >attachment is valid. > > 2. It stores a bunch of state about

[PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-19 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The check_attach_btf_id() function really does three things: 1. It performs a bunch of checks on the program to ensure that the attachment is valid. 2. It stores a bunch of state about the attachment being requested in the verifier environment and struct bpf_p