Re: [PATCH bpf-next v6 5/6] ipv6: sr: Add seg6local action End.BPF

2018-05-20 Thread Mathieu Xhonneux
2018-05-18 21:24 GMT+01:00 Daniel Borkmann : >> +#define MAX_PROG_NAME 256 >> +static const struct nla_policy bpf_prog_policy[LWT_BPF_PROG_MAX + 1] = { >> + [LWT_BPF_PROG_FD] = { .type = NLA_U32, }, > > From UAPI point of view, I wouldn't name it LWT_BPF_PROG_FD but rather > something like >

Re: [PATCH bpf-next v6 5/6] ipv6: sr: Add seg6local action End.BPF

2018-05-18 Thread Daniel Borkmann
On 05/17/2018 04:28 PM, Mathieu Xhonneux wrote: > This patch adds the End.BPF action to the LWT seg6local infrastructure. > This action works like any other seg6local End action, meaning that an IPv6 > header with SRH is needed, whose DA has to be equal to the SID of the > action. It will also adva

[PATCH bpf-next v6 5/6] ipv6: sr: Add seg6local action End.BPF

2018-05-17 Thread Mathieu Xhonneux
This patch adds the End.BPF action to the LWT seg6local infrastructure. This action works like any other seg6local End action, meaning that an IPv6 header with SRH is needed, whose DA has to be equal to the SID of the action. It will also advance the SRH to the next segment, the BPF program does no