Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-17 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Thu, Sep 17, 2020 at 3:06 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >> >> >> >> +int bpf_check_attach_target(struct bpf_verifier_log *log, >> >> + const struct bpf_prog *prog, >> >> + con

Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-17 Thread Andrii Nakryiko
On Thu, Sep 17, 2020 at 3:06 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > >> > >> +int bpf_check_attach_target(struct bpf_verifier_log *log, > >> + const struct bpf_prog *prog, > >> + const struct bpf_prog *tgt_prog, > >> +

Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-17 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: >> >> +int bpf_check_attach_target(struct bpf_verifier_log *log, >> + const struct bpf_prog *prog, >> + const struct bpf_prog *tgt_prog, >> + u32 btf_id, >> + struct btf

Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-16 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Sep 15, 2020 at 5:50 PM Toke Høiland-Jørgensen > wrote: >> >> From: Toke Høiland-Jørgensen >> >> The check_attach_btf_id() function really does three things: >> >> 1. It performs a bunch of checks on the program to ensure that the >>attachment is valid. >>

Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-16 Thread Andrii Nakryiko
On Tue, Sep 15, 2020 at 5:50 PM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > The check_attach_btf_id() function really does three things: > > 1. It performs a bunch of checks on the program to ensure that the >attachment is valid. > > 2. It stores a bunch of state about

[PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-15 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The check_attach_btf_id() function really does three things: 1. It performs a bunch of checks on the program to ensure that the attachment is valid. 2. It stores a bunch of state about the attachment being requested in the verifier environment and struct bpf_p