Re: [PATCH bpf-next v5 15/15] selftests/bpf: Tests for BPF_SK_LOOKUP attach point

2020-07-30 Thread Daniel Borkmann
On 7/29/20 10:55 AM, Jakub Sitnicki wrote: Hi Daniel, On Tue, Jul 28, 2020 at 10:47 PM CEST, Daniel Borkmann wrote: [...] Jakub, I'm actually seeing a slightly different one on my test machine with sk_lookup: # ./test_progs -t sk_lookup #14 cgroup_skb_sk_lookup:OK #73/1 query lookup prog:OK

Re: [PATCH bpf-next v5 15/15] selftests/bpf: Tests for BPF_SK_LOOKUP attach point

2020-07-30 Thread Andrii Nakryiko
On Thu, Jul 30, 2020 at 6:10 AM Jakub Sitnicki wrote: > > On Wed, Jul 29, 2020 at 10:57 AM CEST, Jakub Sitnicki wrote: > > On Tue, Jul 28, 2020 at 10:13 PM CEST, Andrii Nakryiko wrote: > > > > [...] > > > >> We are getting this failure in Travis CI when syncing libbpf [0]: > >> > >> ``` > >> ip: e

Re: [PATCH bpf-next v5 15/15] selftests/bpf: Tests for BPF_SK_LOOKUP attach point

2020-07-30 Thread Jakub Sitnicki
On Wed, Jul 29, 2020 at 10:57 AM CEST, Jakub Sitnicki wrote: > On Tue, Jul 28, 2020 at 10:13 PM CEST, Andrii Nakryiko wrote: > > [...] > >> We are getting this failure in Travis CI when syncing libbpf [0]: >> >> ``` >> ip: either "local" is duplicate, or "nodad" is garbage >> >> switch_netns:PASS:u

Re: [PATCH bpf-next v5 15/15] selftests/bpf: Tests for BPF_SK_LOOKUP attach point

2020-07-29 Thread Jakub Sitnicki
Hi Andrii, On Tue, Jul 28, 2020 at 10:13 PM CEST, Andrii Nakryiko wrote: [...] > We are getting this failure in Travis CI when syncing libbpf [0]: > > ``` > ip: either "local" is duplicate, or "nodad" is garbage > > switch_netns:PASS:unshare 0 nsec > > switch_netns:FAIL:system failed > > (/home/

Re: [PATCH bpf-next v5 15/15] selftests/bpf: Tests for BPF_SK_LOOKUP attach point

2020-07-29 Thread Jakub Sitnicki
Hi Daniel, On Tue, Jul 28, 2020 at 10:47 PM CEST, Daniel Borkmann wrote: [...] > Jakub, I'm actually seeing a slightly different one on my test machine with > sk_lookup: > > # ./test_progs -t sk_lookup > #14 cgroup_skb_sk_lookup:OK > #73/1 query lookup prog:OK > #73/2 TCP IPv4 redir port:OK > #

Re: [PATCH bpf-next v5 15/15] selftests/bpf: Tests for BPF_SK_LOOKUP attach point

2020-07-28 Thread Daniel Borkmann
On 7/28/20 10:13 PM, Andrii Nakryiko wrote: On Fri, Jul 17, 2020 at 3:36 AM Jakub Sitnicki wrote: Add tests to test_progs that exercise: - attaching/detaching/querying programs to BPF_SK_LOOKUP hook, - redirecting socket lookup to a socket selected by BPF program, - failing a socket loo

Re: [PATCH bpf-next v5 15/15] selftests/bpf: Tests for BPF_SK_LOOKUP attach point

2020-07-28 Thread Andrii Nakryiko
On Fri, Jul 17, 2020 at 3:36 AM Jakub Sitnicki wrote: > > Add tests to test_progs that exercise: > > - attaching/detaching/querying programs to BPF_SK_LOOKUP hook, > - redirecting socket lookup to a socket selected by BPF program, > - failing a socket lookup on BPF program's request, > - error

[PATCH bpf-next v5 15/15] selftests/bpf: Tests for BPF_SK_LOOKUP attach point

2020-07-17 Thread Jakub Sitnicki
Add tests to test_progs that exercise: - attaching/detaching/querying programs to BPF_SK_LOOKUP hook, - redirecting socket lookup to a socket selected by BPF program, - failing a socket lookup on BPF program's request, - error scenarios for selecting a socket from BPF program, - accessing BPF