Re: please revert [PATCH bpf-next v5 03/15] xsk: create and free buffer pool independently from umem

2020-10-05 Thread Björn Töpel
On 2020-10-05 10:43, Christoph Hellwig wrote: On Mon, Oct 05, 2020 at 09:35:35AM +0100, Christoph Hellwig wrote: Hi Dave, please can you rever this? This is the second xsk patch this year that pokes into dma-mapping internals for absolutely not reason. And we discussed this in detail the last

Re: please revert [PATCH bpf-next v5 03/15] xsk: create and free buffer pool independently from umem

2020-10-05 Thread Christoph Hellwig
On Mon, Oct 05, 2020 at 09:35:35AM +0100, Christoph Hellwig wrote: > Hi Dave, > > please can you rever this? This is the second xsk patch this year > that pokes into dma-mapping internals for absolutely not reason. > > And we discussed this in detail the last time around: drivers have > absolute

please revert [PATCH bpf-next v5 03/15] xsk: create and free buffer pool independently from umem

2020-10-05 Thread Christoph Hellwig
Hi Dave, please can you rever this? This is the second xsk patch this year that pokes into dma-mapping internals for absolutely not reason. And we discussed this in detail the last time around: drivers have absolutely no business poking into dma-direct.h and dma-noncoherent.h. In fact because pe

[PATCH bpf-next v5 03/15] xsk: create and free buffer pool independently from umem

2020-08-28 Thread Magnus Karlsson
Create and free the buffer pool independently from the umem. Move these operations that are performed on the buffer pool from the umem create and destroy functions to new create and destroy functions just for the buffer pool. This so that in later commits we can instantiate multiple buffer pools pe