Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

2019-01-31 Thread Jesper Dangaard Brouer
On Wed, 30 Jan 2019 18:26:53 -0800 Jakub Kicinski wrote: > On Wed, 30 Jan 2019 20:08:59 +0100, Jesper Dangaard Brouer wrote: > > > I'll post a v5 with libbpf_strerror() usage when bpf_set_link_xdp_fd > > > failed in > > > samples but at this point it will only give us a standard "device or > >

Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

2019-01-30 Thread Jakub Kicinski
On Wed, 30 Jan 2019 20:08:59 +0100, Jesper Dangaard Brouer wrote: > > I'll post a v5 with libbpf_strerror() usage when bpf_set_link_xdp_fd failed > > in > > samples but at this point it will only give us a standard "device or > > resource > > busy" error > > That is a good first iteration impr

Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

2019-01-30 Thread Jesper Dangaard Brouer
On Wed, 30 Jan 2019 19:12:48 +0100 Maciej Fijalkowski wrote: > On Tue, 29 Jan 2019 12:34:05 +0100 > Jesper Dangaard Brouer wrote: > > > On Tue, 29 Jan 2019 09:00:00 +0100 > > Jesper Dangaard Brouer wrote: > > > > > On Mon, 28 Jan 2019 20:16:11 +0100 > > > Maciej Fijalkowski wrote: > > >

Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

2019-01-30 Thread Maciej Fijalkowski
On Tue, 29 Jan 2019 12:34:05 +0100 Jesper Dangaard Brouer wrote: > On Tue, 29 Jan 2019 09:00:00 +0100 > Jesper Dangaard Brouer wrote: > > > On Mon, 28 Jan 2019 20:16:11 +0100 > > Maciej Fijalkowski wrote: > > > > > From: Maciej Fijalkowski > > > > > > Make xdp samples consistent with ipro

Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

2019-01-29 Thread Jesper Dangaard Brouer
On Tue, 29 Jan 2019 09:00:00 +0100 Jesper Dangaard Brouer wrote: > On Mon, 28 Jan 2019 20:16:11 +0100 > Maciej Fijalkowski wrote: > > > From: Maciej Fijalkowski > > > > Make xdp samples consistent with iproute2 behavior and set the > > XDP_FLAGS_UPDATE_IF_NOEXIST by default when setting the x

Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

2019-01-29 Thread Jesper Dangaard Brouer
On Mon, 28 Jan 2019 20:16:11 +0100 Maciej Fijalkowski wrote: > From: Maciej Fijalkowski > > Make xdp samples consistent with iproute2 behavior and set the > XDP_FLAGS_UPDATE_IF_NOEXIST by default when setting the xdp program on > interface. Provide an option for user to force the program loadin

Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

2019-01-28 Thread John Fastabend
On 1/28/19 11:16 AM, Maciej Fijalkowski wrote: > From: Maciej Fijalkowski > > Make xdp samples consistent with iproute2 behavior and set the > XDP_FLAGS_UPDATE_IF_NOEXIST by default when setting the xdp program on > interface. Provide an option for user to force the program loading, > which as a

[PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

2019-01-28 Thread Maciej Fijalkowski
From: Maciej Fijalkowski Make xdp samples consistent with iproute2 behavior and set the XDP_FLAGS_UPDATE_IF_NOEXIST by default when setting the xdp program on interface. Provide an option for user to force the program loading, which as a result will not include the mentioned flag in bpf_set_link_