Re: [PATCH bpf-next v4 05/14] xsk: move queue_id, dev and need_wakeup to buffer pool

2020-07-29 Thread Magnus Karlsson
On Tue, Jul 28, 2020 at 11:22 AM Maxim Mikityanskiy wrote: > > On 2020-07-21 08:03, Magnus Karlsson wrote: > > Move queue_id, dev, and need_wakeup from the umem to the > > buffer pool. This so that we in a later commit can share the umem > > between multiple HW queues. There is one buffer pool per

Re: [PATCH bpf-next v4 05/14] xsk: move queue_id, dev and need_wakeup to buffer pool

2020-07-29 Thread Magnus Karlsson
On Tue, Jul 28, 2020 at 9:10 AM Björn Töpel wrote: > > > > On 2020-07-21 07:03, Magnus Karlsson wrote: > > Move queue_id, dev, and need_wakeup from the umem to the > > buffer pool. This so that we in a later commit can share the umem > > between multiple HW queues. There is one buffer pool per dev

Re: [PATCH bpf-next v4 05/14] xsk: move queue_id, dev and need_wakeup to buffer pool

2020-07-28 Thread Maxim Mikityanskiy
On 2020-07-21 08:03, Magnus Karlsson wrote: Move queue_id, dev, and need_wakeup from the umem to the buffer pool. This so that we in a later commit can share the umem between multiple HW queues. There is one buffer pool per dev and queue id, so these variables should belong to the buffer pool, no

Re: [PATCH bpf-next v4 05/14] xsk: move queue_id, dev and need_wakeup to buffer pool

2020-07-28 Thread Björn Töpel
On 2020-07-21 07:03, Magnus Karlsson wrote: Move queue_id, dev, and need_wakeup from the umem to the buffer pool. This so that we in a later commit can share the umem between multiple HW queues. There is one buffer pool per dev and queue id, so these variables should belong to the buffer pool,

[PATCH bpf-next v4 05/14] xsk: move queue_id, dev and need_wakeup to buffer pool

2020-07-20 Thread Magnus Karlsson
Move queue_id, dev, and need_wakeup from the umem to the buffer pool. This so that we in a later commit can share the umem between multiple HW queues. There is one buffer pool per dev and queue id, so these variables should belong to the buffer pool, not the umem. Need_wakeup is also something that