Re: [PATCH bpf-next v3 4/8] libbpf: implement bpf_prog_find_metadata

2020-09-02 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Wed, Sep 02, 2020 at 11:43:26AM +0200, Toke Høiland-Jørgensen wrote: >> > >> > I don't feel great about this libbpf api. bpftool already does >> > bpf_obj_get_info_by_fd() for progs and for maps. >> > This extra step and extra set of syscalls is redundant wor

Re: [PATCH bpf-next v3 4/8] libbpf: implement bpf_prog_find_metadata

2020-09-02 Thread Alexei Starovoitov
On Wed, Sep 02, 2020 at 11:43:26AM +0200, Toke Høiland-Jørgensen wrote: > > > > I don't feel great about this libbpf api. bpftool already does > > bpf_obj_get_info_by_fd() for progs and for maps. > > This extra step and extra set of syscalls is redundant work. > > I think it's better to be done as

Re: [PATCH bpf-next v3 4/8] libbpf: implement bpf_prog_find_metadata

2020-09-02 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Mon, Aug 31, 2020 at 08:40:01AM -0700, s...@google.com wrote: >> On 08/28, Toke H�iland-J�rgensen wrote: >> > Stanislav Fomichev writes: >> >> > > This is a low-level function (hence in bpf.c) to find out the metadata >> > > map id for the provided program fd. >>

Re: [PATCH bpf-next v3 4/8] libbpf: implement bpf_prog_find_metadata

2020-09-01 Thread Alexei Starovoitov
On Mon, Aug 31, 2020 at 08:40:01AM -0700, s...@google.com wrote: > On 08/28, Toke H�iland-J�rgensen wrote: > > Stanislav Fomichev writes: > > > > This is a low-level function (hence in bpf.c) to find out the metadata > > > map id for the provided program fd. > > > It will be used in the next comm

Re: [PATCH bpf-next v3 4/8] libbpf: implement bpf_prog_find_metadata

2020-08-31 Thread sdf
On 08/28, Toke H�iland-J�rgensen wrote: Stanislav Fomichev writes: > This is a low-level function (hence in bpf.c) to find out the metadata > map id for the provided program fd. > It will be used in the next commits from bpftool. > > Cc: Toke H�iland-J�rgensen > Cc: YiFei Zhu > Signed-off-b

Re: [PATCH bpf-next v3 4/8] libbpf: implement bpf_prog_find_metadata

2020-08-28 Thread Toke Høiland-Jørgensen
Stanislav Fomichev writes: > This is a low-level function (hence in bpf.c) to find out the metadata > map id for the provided program fd. > It will be used in the next commits from bpftool. > > Cc: Toke Høiland-Jørgensen > Cc: YiFei Zhu > Signed-off-by: Stanislav Fomichev > --- > tools/lib/bp