Re: static bpf vars. Was: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-05 Thread Daniel Borkmann
On 03/05/2019 03:28 AM, Alexei Starovoitov wrote: > On Fri, Mar 01, 2019 at 09:06:35PM +0100, Daniel Borkmann wrote: > > Overall I think the patches and direction is great. > Thanks a lot for working on it. > More thoughts below: Okay, thanks! >> By the way, from LLVM side, do you think it makes

static bpf vars. Was: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-04 Thread Alexei Starovoitov
On Fri, Mar 01, 2019 at 09:06:35PM +0100, Daniel Borkmann wrote: > Overall I think the patches and direction is great. Thanks a lot for working on it. More thoughts below: > By the way, from LLVM side, do you think it makes sense for local vars > where you encode the offset into insn->imm to alr

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Daniel Borkmann
On 03/02/2019 01:23 AM, Yonghong Song wrote: > On 2/28/19 4:19 PM, Daniel Borkmann wrote: >> On 03/01/2019 12:41 AM, Stanislav Fomichev wrote: >>> On 03/01, Daniel Borkmann wrote: This work adds BPF loader support for global data sections to libbpf. This allows to write BPF programs in mo

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Yonghong Song
On 2/28/19 4:19 PM, Daniel Borkmann wrote: > On 03/01/2019 12:41 AM, Stanislav Fomichev wrote: >> On 03/01, Daniel Borkmann wrote: >>> This work adds BPF loader support for global data sections >>> to libbpf. This allows to write BPF programs in more natural >>> C-like way by being able to define

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 09:25 PM, Yonghong Song wrote: > On 3/1/19 12:06 PM, Daniel Borkmann wrote: >> On 03/01/2019 08:19 PM, Yonghong Song wrote: >>> On 3/1/19 11:10 AM, Andrii Nakryiko wrote: On Fri, Mar 1, 2019 at 10:58 AM Yonghong Song wrote: > On 3/1/19 10:48 AM, Andrii Nakryiko wrote: >>

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Yonghong Song
On 3/1/19 12:06 PM, Daniel Borkmann wrote: > On 03/01/2019 08:19 PM, Yonghong Song wrote: >> On 3/1/19 11:10 AM, Andrii Nakryiko wrote: >>> On Fri, Mar 1, 2019 at 10:58 AM Yonghong Song wrote: On 3/1/19 10:48 AM, Andrii Nakryiko wrote: > On Fri, Mar 1, 2019 at 10:31 AM Yonghong Song wr

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 08:19 PM, Yonghong Song wrote: > On 3/1/19 11:10 AM, Andrii Nakryiko wrote: >> On Fri, Mar 1, 2019 at 10:58 AM Yonghong Song wrote: >>> On 3/1/19 10:48 AM, Andrii Nakryiko wrote: On Fri, Mar 1, 2019 at 10:31 AM Yonghong Song wrote: > On 2/28/19 3:18 PM, Daniel Borkmann wrot

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 07:11 PM, Yonghong Song wrote: > On 2/28/19 3:18 PM, Daniel Borkmann wrote: [...] >> @@ -1412,6 +1568,24 @@ bpf_program__relocate(struct bpf_program *prog, >> struct bpf_object *obj) >>&prog->reloc_desc[i]); >>

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Yonghong Song
On 3/1/19 11:10 AM, Andrii Nakryiko wrote: > On Fri, Mar 1, 2019 at 10:58 AM Yonghong Song wrote: >> >> >> >> On 3/1/19 10:48 AM, Andrii Nakryiko wrote: >>> On Fri, Mar 1, 2019 at 10:31 AM Yonghong Song wrote: On 2/28/19 3:18 PM, Daniel Borkmann wrote: > This work adds B

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Andrii Nakryiko
On Fri, Mar 1, 2019 at 10:58 AM Yonghong Song wrote: > > > > On 3/1/19 10:48 AM, Andrii Nakryiko wrote: > > On Fri, Mar 1, 2019 at 10:31 AM Yonghong Song wrote: > >> > >> > >> > >> On 2/28/19 3:18 PM, Daniel Borkmann wrote: > >>> This work adds BPF loader support for global data sections > >>> to

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Yonghong Song
On 3/1/19 10:48 AM, Andrii Nakryiko wrote: > On Fri, Mar 1, 2019 at 10:31 AM Yonghong Song wrote: >> >> >> >> On 2/28/19 3:18 PM, Daniel Borkmann wrote: >>> This work adds BPF loader support for global data sections >>> to libbpf. This allows to write BPF programs in more natural >>> C-like way

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Andrii Nakryiko
On Fri, Mar 1, 2019 at 10:31 AM Yonghong Song wrote: > > > > On 2/28/19 3:18 PM, Daniel Borkmann wrote: > > This work adds BPF loader support for global data sections > > to libbpf. This allows to write BPF programs in more natural > > C-like way by being able to define global variables and const

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Andrii Nakryiko
On Fri, Mar 1, 2019 at 2:46 AM Daniel Borkmann wrote: > > On 03/01/2019 07:53 AM, Andrii Nakryiko wrote: > > On Thu, Feb 28, 2019 at 3:31 PM Daniel Borkmann > > wrote: > >> > >> This work adds BPF loader support for global data sections > >> to libbpf. This allows to write BPF programs in more n

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Yonghong Song
On 2/28/19 3:18 PM, Daniel Borkmann wrote: > This work adds BPF loader support for global data sections > to libbpf. This allows to write BPF programs in more natural > C-like way by being able to define global variables and const > data. > > Back at LPC 2018 [0] we presented a first prototype w

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Stanislav Fomichev
On 03/01, Daniel Borkmann wrote: > On 03/01/2019 07:53 AM, Andrii Nakryiko wrote: > > On Thu, Feb 28, 2019 at 3:31 PM Daniel Borkmann > > wrote: > >> > >> This work adds BPF loader support for global data sections > >> to libbpf. This allows to write BPF programs in more natural > >> C-like way b

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 07:53 AM, Andrii Nakryiko wrote: > On Thu, Feb 28, 2019 at 3:31 PM Daniel Borkmann wrote: >> >> This work adds BPF loader support for global data sections >> to libbpf. This allows to write BPF programs in more natural >> C-like way by being able to define global variables and const

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-02-28 Thread Andrii Nakryiko
On Thu, Feb 28, 2019 at 3:31 PM Daniel Borkmann wrote: > > This work adds BPF loader support for global data sections > to libbpf. This allows to write BPF programs in more natural > C-like way by being able to define global variables and const > data. > > Back at LPC 2018 [0] we presented a first

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-02-28 Thread Daniel Borkmann
On 03/01/2019 12:41 AM, Stanislav Fomichev wrote: > On 03/01, Daniel Borkmann wrote: >> This work adds BPF loader support for global data sections >> to libbpf. This allows to write BPF programs in more natural >> C-like way by being able to define global variables and const >> data. >> >> Back at

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-02-28 Thread Stanislav Fomichev
On 03/01, Daniel Borkmann wrote: > This work adds BPF loader support for global data sections > to libbpf. This allows to write BPF programs in more natural > C-like way by being able to define global variables and const > data. > > Back at LPC 2018 [0] we presented a first prototype which > imple

[PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-02-28 Thread Daniel Borkmann
This work adds BPF loader support for global data sections to libbpf. This allows to write BPF programs in more natural C-like way by being able to define global variables and const data. Back at LPC 2018 [0] we presented a first prototype which implemented support for global data sections by exte