Re: [PATCH bpf-next v2 07/15] bpf: offload: add map offload infrastructure

2018-01-14 Thread Daniel Borkmann
On 01/15/2018 12:52 AM, Jakub Kicinski wrote: > On Sun, Jan 14, 2018 at 3:37 PM, Daniel Borkmann wrote: >> Hi Jakub, >> >> Series looks fine, just stumbled over one small thing here below. >> >> On 01/12/2018 05:29 AM, Jakub Kicinski wrote: >> [...] >>> +bool bpf_offload_dev_match(struct bpf_prog

Re: [PATCH bpf-next v2 07/15] bpf: offload: add map offload infrastructure

2018-01-14 Thread Jakub Kicinski
On Sun, Jan 14, 2018 at 3:37 PM, Daniel Borkmann wrote: > Hi Jakub, > > Series looks fine, just stumbled over one small thing here below. > > On 01/12/2018 05:29 AM, Jakub Kicinski wrote: > [...] >> +bool bpf_offload_dev_match(struct bpf_prog *prog, struct bpf_map *map) >> +{ >> + struct bpf_o

Re: [PATCH bpf-next v2 07/15] bpf: offload: add map offload infrastructure

2018-01-14 Thread Daniel Borkmann
Hi Jakub, Series looks fine, just stumbled over one small thing here below. On 01/12/2018 05:29 AM, Jakub Kicinski wrote: [...] > +bool bpf_offload_dev_match(struct bpf_prog *prog, struct bpf_map *map) > +{ > + struct bpf_offloaded_map *offmap; > + struct bpf_prog_offload *offload; > +

[PATCH bpf-next v2 07/15] bpf: offload: add map offload infrastructure

2018-01-11 Thread Jakub Kicinski
BPF map offload follow similar path to program offload. At creation time users may specify ifindex of the device on which they want to create the map. Map will be validated by the kernel's .map_alloc_check callback and device driver will be called for the actual allocation. Map will have an empt