Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-15 Thread Daniel Borkmann
On 08/13/2018 02:22 PM, Daniel Borkmann wrote: [...] > I'll get the patch in once it has been pulled. Applied to bpf, thanks Tariq!

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Daniel Borkmann
On 08/13/2018 02:02 PM, Jesper Dangaard Brouer wrote: > On Mon, 13 Aug 2018 13:57:04 +0300 > Tariq Toukan wrote: >> On 13/08/2018 1:31 PM, Jesper Dangaard Brouer wrote: >>> On Mon, 13 Aug 2018 12:21:58 +0300 >>> Tariq Toukan wrote: [...] >>> In the example[1], the sequence is wrapped in rcu_read_

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Jesper Dangaard Brouer
On Mon, 13 Aug 2018 13:57:04 +0300 Tariq Toukan wrote: > On 13/08/2018 1:31 PM, Jesper Dangaard Brouer wrote: > > On Mon, 13 Aug 2018 12:21:58 +0300 > > Tariq Toukan wrote: > > > >> Fix the warning below by calling rhashtable_lookup_fast. > >> Also, make some code movements for better quality

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Tariq Toukan
On 13/08/2018 1:31 PM, Jesper Dangaard Brouer wrote: On Mon, 13 Aug 2018 12:21:58 +0300 Tariq Toukan wrote: Fix the warning below by calling rhashtable_lookup_fast. Also, make some code movements for better quality and human readability. [ 342.450870] WARNING: suspicious RCU usage [ 342.

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Jesper Dangaard Brouer
On Mon, 13 Aug 2018 12:21:58 +0300 Tariq Toukan wrote: > Fix the warning below by calling rhashtable_lookup_fast. > Also, make some code movements for better quality and human > readability. > > [ 342.450870] WARNING: suspicious RCU usage > [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O

[PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

2018-08-13 Thread Tariq Toukan
Fix the warning below by calling rhashtable_lookup_fast. Also, make some code movements for better quality and human readability. [ 342.450870] WARNING: suspicious RCU usage [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O [ 342.462210] - [ 342.467202] ./include