Re: [PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

2019-06-17 Thread Stanislav Fomichev
On 06/17, Andrii Nakryiko wrote: > On Fri, Jun 14, 2019 at 5:01 PM Stanislav Fomichev wrote: > > > > On 06/14, Andrii Nakryiko wrote: > > > On Fri, Jun 14, 2019 at 4:23 PM Stanislav Fomichev > > > wrote: > > > > > > > > On 06/10, Andrii Nakryiko wrote: > > > > > Switch test map definition to new

Re: [PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

2019-06-17 Thread Andrii Nakryiko
On Fri, Jun 14, 2019 at 5:01 PM Stanislav Fomichev wrote: > > On 06/14, Andrii Nakryiko wrote: > > On Fri, Jun 14, 2019 at 4:23 PM Stanislav Fomichev wrote: > > > > > > On 06/10, Andrii Nakryiko wrote: > > > > Switch test map definition to new BTF-defined format. > > > Reiterating my concerns on

Re: [PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

2019-06-14 Thread Stanislav Fomichev
On 06/14, Andrii Nakryiko wrote: > On Fri, Jun 14, 2019 at 4:23 PM Stanislav Fomichev wrote: > > > > On 06/10, Andrii Nakryiko wrote: > > > Switch test map definition to new BTF-defined format. > > Reiterating my concerns on non-RFC version: > > > > Pretty please, let's not convert everything at o

Re: [PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

2019-06-14 Thread Andrii Nakryiko
On Fri, Jun 14, 2019 at 4:23 PM Stanislav Fomichev wrote: > > On 06/10, Andrii Nakryiko wrote: > > Switch test map definition to new BTF-defined format. > Reiterating my concerns on non-RFC version: > > Pretty please, let's not convert everything at once. Let's start > with stuff that explicitly d

Re: [PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

2019-06-14 Thread Stanislav Fomichev
On 06/10, Andrii Nakryiko wrote: > Switch test map definition to new BTF-defined format. Reiterating my concerns on non-RFC version: Pretty please, let's not convert everything at once. Let's start with stuff that explicitly depends on BTF (spinlocks?). One good argument (aside from the one that

[PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

2019-06-10 Thread Andrii Nakryiko
Switch test map definition to new BTF-defined format. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/progs/bpf_flow.c | 18 +++-- .../selftests/bpf/progs/get_cgroup_id_kern.c | 18 +++-- .../testing/selftests/bpf/progs/netcnt_prog.c | 22 +++--- .../selftests/bpf/progs/sample_m

[RFC PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

2019-06-10 Thread Andrii Nakryiko
Switch test map definition to new BTF-defined format. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/progs/bpf_flow.c | 18 +++-- .../selftests/bpf/progs/get_cgroup_id_kern.c | 18 +++-- .../testing/selftests/bpf/progs/netcnt_prog.c | 22 +++--- .../selftests/bpf/progs/sample_m

[RFC PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

2019-05-31 Thread Andrii Nakryiko
Switch test map definition to new BTF-defined format. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/progs/bpf_flow.c | 18 +++-- .../selftests/bpf/progs/get_cgroup_id_kern.c | 18 +++-- .../testing/selftests/bpf/progs/netcnt_prog.c | 22 +++--- .../selftests/bpf/progs/sample_m